-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: enable importas for k8s.io/apimachinery/pkg/api/errors #21262
Open
mmorel-35
wants to merge
1
commit into
argoproj:master
Choose a base branch
from
mmorel-35:importas
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+139
−140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❗ Preview Environment deployment failed on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
mmorel-35
force-pushed
the
importas
branch
4 times, most recently
from
December 19, 2024 18:00
f6c79ac
to
f8c4c76
Compare
mmorel-35
changed the title
chore: enable importas
chore: enable importas for k8s.io/apimachinery/pkg/api/errors
Dec 19, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21262 +/- ##
==========================================
- Coverage 55.19% 55.18% -0.02%
==========================================
Files 337 337
Lines 57058 57058
==========================================
- Hits 31496 31488 -8
- Misses 22863 22866 +3
- Partials 2699 2704 +5 ☔ View full report in Codecov by Sentry. |
mmorel-35
force-pushed
the
importas
branch
5 times, most recently
from
December 25, 2024 20:57
5bddfbb
to
4f9ed81
Compare
andrii-korotkov-verkada
approved these changes
Dec 29, 2024
reggie-k
approved these changes
Dec 29, 2024
Signed-off-by: Matthieu MOREL <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Importas helps ensure consistency of imports aliases.
This is only for
k8s.io/apimachinery/pkg/api/errors
yet here