Feat/restart apps button applications list v2.12.3 #21306
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: ishitasequeira <[email protected]>
…rgoproj#18733) There are some situations where the project will be `undefined`. When that happens, attempting to delete a repo won't be possible, since the backend will be looking for a project with the literal name `undefined`. To fix this, set an empty string for `undefined|null` values. Signed-off-by: Blake Pettersson <[email protected]> Co-authored-by: Blake Pettersson <[email protected]>
) (argoproj#18763) (argoproj#18782) * fix(server): could not find source for metadata revision (argoproj#18744) * lint * the linter behaves poorly * fix test * share logic with chart endpoint * more intuitive check * remove debug line --------- Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]>
) (argoproj#18800) (argoproj#18801) Co-authored-by: Keith Chong <[email protected]>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: crenshaw-dev <[email protected]>
…) (argoproj#18811) Bumps [github.com/hashicorp/go-retryablehttp](https://github.com/hashicorp/go-retryablehttp) from 0.7.4 to 0.7.7. - [Changelog](https://github.com/hashicorp/go-retryablehttp/blob/main/CHANGELOG.md) - [Commits](hashicorp/go-retryablehttp@v0.7.4...v0.7.7) --- updated-dependencies: - dependency-name: github.com/hashicorp/go-retryablehttp dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…d" (argoproj#17062) (argoproj#18781) This reverts commit 86369ca. Signed-off-by: Michael Crenshaw <[email protected]>
) (argoproj#18765) (argoproj#18818) * fix(webhook): bitbucket and azure webhook not triggering refresh * update unit test * fix merge * adjust logic for reposerver using ls-remote --------- Signed-off-by: Alexandre Gaudreault <[email protected]> Co-authored-by: Alexandre Gaudreault <[email protected]>
…rgoproj#18767) (argoproj#18828) * fix: Handle nil health check in post-delete hooks * test: Validate deletion of RBAC resources for post-delete hook * Update appcontroller_test.go --------- Signed-off-by: Yonatan Sasson <[email protected]> Signed-off-by: Yonatan Sasson <[email protected]> Co-authored-by: Yonatan Sasson <[email protected]>
…roj#18873) Signed-off-by: Jaeseok Lee <[email protected]> Co-authored-by: Jaeseok Lee <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: crenshaw-dev <[email protected]>
…roj#18887) (argoproj#18897) Signed-off-by: ishitasequeira <[email protected]> Co-authored-by: Ishita Sequeira <[email protected]>
…j#18951) (argoproj#18955) * Get Redis password from secret in `loadClusters()` * feat: support redis password in admin stats command * Simplify code --------- Signed-off-by: David Wu <[email protected]> Signed-off-by: pashakostohrys <[email protected]> Co-authored-by: david-wu-octopus <[email protected]> Co-authored-by: pashakostohrys <[email protected]>
Signed-off-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: crenshaw-dev <[email protected]>
* fix(applicationset): use requeue after if generate app errors out (argoproj#18761) The `GenerateApplications` can call to external resources like Github API for instance which might be rate limited or fail. If those requests somehow fail we should requeue them after some time like (same reason as https://github.com/argoproj/argo-cd/blob/e98d3b2a877fb7140880dc1450703a99db4398b5/applicationset/controllers/applicationset_controller.go#L154). For instance, in our environments we were rate limited by Github and the ArgoCD applicationset controller was logging the following error about every second or less for every application set using the pull request generator that we have: ``` time="2024-06-21T14:17:15Z" level=error msg="error generating params" error="error listing repos: error listing pull requests for LedgerHQ/xxx: GET https://api.github.com/repos/LedgerHQ/xxx/pulls?per_page=100: 403 API rate limit exceeded for installation ID xxx. If you reach out to GitHub Support for help, please include the request ID xxx and timestamp 2024-06-xx xxx UTC. [rate reset in 8m18s]" generator="&{0xc000d652c0 0x289a100 {0xc00087bdd0} [] true}" time="2024-06-21T14:17:15Z" level=error msg="error generating application from params" applicationset=argocd/xxx error="error listing repos: error listing pull requests for LedgerHQ/xxxx: GET https://api.github.com/repos/LedgerHQ/xxx/pulls?per_page=100: 403 API rate limit exceeded for installation ID xxx. If you reach out to GitHub Support for help, please include the request ID xxx and timestamp 2024-06-xx xxx UTC. [rate reset in 8m18s]" generator="{nil nil nil nil nil &PullRequestGenerator{Github:&PullRequestGeneratorGithub{Owner:LedgerHQ,Repo:xxx,API:,TokenRef:nil,AppSecretName:xxxx,Labels:[argocd/preview],},GitLab:nil,Gitea:nil,BitbucketServer:nil,Filters:[]PullRequestGeneratorFilter{},RequeueAfterSeconds:*1800,Template:ApplicationSetTemplate{ApplicationSetTemplateMeta:ApplicationSetTemplateMeta{Name:,Namespace:,Labels:map[string]string{},Annotations:map[string]string{},Finalizers:[],},Spec:ApplicationSpec{Source:nil,Destination:ApplicationDestination{Server:,Namespace:,Name:,},Project:,SyncPolicy:nil,IgnoreDifferences:[]ResourceIgnoreDifferences{},Info:[]Info{},RevisionHistoryLimit:nil,Sources:[]ApplicationSource{},},},Bitbucket:nil,AzureDevOps:nil,} nil nil nil nil}" ``` Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * test: cherry-pick fixes Signed-off-by: Blake Pettersson <[email protected]> * chore: please the linter Signed-off-by: Blake Pettersson <[email protected]> --------- Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> Signed-off-by: Blake Pettersson <[email protected]> Co-authored-by: Arthur Outhenin-Chalandre <[email protected]>
…" (cherry-pick argoproj#19196) This reverts commit 4d8436b. Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]>
…ith new required values (argoproj#19165) (argoproj#19216) Signed-off-by: wparr-circle <[email protected]> Co-authored-by: William Parr <[email protected]>
…roj#19338) (argoproj#19339) Signed-off-by: Alexandre Gaudreault <[email protected]> Co-authored-by: Alexandre Gaudreault <[email protected]>
…oj#19340) (argoproj#19343) Signed-off-by: Alexander Matyushentsev <[email protected]> Co-authored-by: Alexander Matyushentsev <[email protected]>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: ishitasequeira <[email protected]>
…rgoproj#19304) (argoproj#19360) * add custom health check for awsmanagedcontrolplane * chore(deps): bump github.com/aws/aws-sdk-go from 1.55.3 to 1.55.4 (argoproj#19295) Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.55.3 to 1.55.4. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](aws/aws-sdk-go@v1.55.3...v1.55.4) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... * add new line at the end of health_test.yaml file --------- Signed-off-by: Iulian Taiatu <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: itaiatu <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: ishitasequeira <[email protected]>
Signed-off-by: jasong <[email protected]>
…argoproj#19430) (argoproj#19435) Signed-off-by: Dmitry Khodorov <[email protected]> Co-authored-by: Dmitry Khodorov <[email protected]>
…) (argoproj#19534) * document templating project field while using applicationset git generator and signature verification * revert changes to generated mocks * Add check for templated project field and add limitation to the docs * optimize checks and rephrase documentation * remove unwanted variable declaration * Add unit tests --------- Signed-off-by: Ishita Sequeira <[email protected]> Co-authored-by: Ishita Sequeira <[email protected]>
… generators (argoproj#19558) * fix appset-in-any-namespace issue with git generators Signed-off-by: Ishita Sequeira <[email protected]> * fix lint issue Signed-off-by: Ishita Sequeira <[email protected]> --------- Signed-off-by: Ishita Sequeira <[email protected]>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: ishitasequeira <[email protected]>
…rgoproj#19488) (argoproj#19602) Signed-off-by: Siddhesh Ghadi <[email protected]> Co-authored-by: Siddhesh Ghadi <[email protected]> Co-authored-by: Jann Fischer <[email protected]>
…) (argoproj#19623) (argoproj#19627) Signed-off-by: Keith Chong <[email protected]> Co-authored-by: Keith Chong <[email protected]>
…rgoproj#19618) (argoproj#19636) Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: rumstead <[email protected]>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: crenshaw-dev <[email protected]>
argoproj#19664) * feat(sourceNamespace): Regex Support * feat(sourceNamespace): Separate exactMatch into patternMatch --------- Signed-off-by: Arthur <[email protected]> Co-authored-by: Arthur Vardevanyan <[email protected]>
…oj#19516) (argoproj#19665) Signed-off-by: Arthur <[email protected]> Co-authored-by: Arthur Vardevanyan <[email protected]>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: ishitasequeira <[email protected]>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
audip
restored the
feat/restart-apps-button-applications-list-v2.12.3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to add UI feature that has been mentioned in #21305
Fixes #21305
Checklist: