-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update getting_started.md to emphasize the usage of http/2 #21313
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Revital Barletz <[email protected]>
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Signed-off-by: Revital Barletz <[email protected]>
@senayuki will appreciate your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this is a common issue? Are there linked issues for this?
@@ -52,7 +52,9 @@ Also available in Mac, Linux and WSL Homebrew: | |||
```bash | |||
brew install argocd | |||
``` | |||
|
|||
!!! note | |||
To ensure proper functionality, the Argo CD CLI requires HTTP/2 support. Verify that your CLI is set up to use HTTP/2, especially if connecting to an Argo CD server over HTTPS. Check your system’s configuration or proxy settings if issues arise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To ensure proper functionality, the Argo CD CLI requires HTTP/2 support. Verify that your CLI is set up to use HTTP/2, especially if connecting to an Argo CD server over HTTPS. Check your system’s configuration or proxy settings if issues arise. | |
To ensure proper functionality, the Argo CD CLI requires HTTP/2 support. Verify that your CLI is set up to use HTTP/2, especially if connecting to an Argo CD server over HTTPS. Check your system’s configuration or proxy settings if issues arise. |
- Why do we need to emphasize on usage of http/2 here?
- Can you add steps that would be required for verification if CLI I set up to use the HTTP/2?
- Which issue can occur if you just normally install the Argo CD CLI and use it against the Argo CD server over HTTPS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL. I'd also suggest creating an issue first before raising a PR. This will help address the concern more clearly.
I apologize that I didn't check mentions recently. In fact, this issue was raised by me in #20715. I am not a core user of argo-cd, but I raised the issue as an amateur. This may need more discussion or it might not be an issue at all. And this PR might be related to #20639. Perhaps it has already been fixed? My issue is in v2.13.0. |
So the issue is really related to ingress in this case and not the cli per se. Is there a troubleshooting section where this would fit more readily? |
Indeed it is related to #20715. My understanding is that it is related to missing notes about http/2... but I see your point @todaywasawesome - do you think that there is a better fit for this comment? |
Checklist: