Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add script to bump major version #21363

Merged

Conversation

crenshaw-dev
Copy link
Member

@crenshaw-dev crenshaw-dev commented Jan 3, 2025

The PR for bumping major versions touches hundreds of files. To ease the review process, I want a script we can run and be confident that the only changes are the ones made by the script.

I've validated the script by running it locally, then running codegen, lint, and unit tests.

You can see an example of the generated PR here: crenshaw-dev#30

@crenshaw-dev crenshaw-dev marked this pull request as ready for review January 3, 2025 19:42
@crenshaw-dev crenshaw-dev requested a review from a team as a code owner January 3, 2025 19:42
Copy link

bunnyshell bot commented Jan 3, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@crenshaw-dev crenshaw-dev requested a review from a team as a code owner January 3, 2025 19:49
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.17%. Comparing base (5508d1f) to head (f848766).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21363      +/-   ##
==========================================
- Coverage   55.20%   55.17%   -0.04%     
==========================================
  Files         337      337              
  Lines       57057    57057              
==========================================
- Hits        31501    31483      -18     
- Misses      22858    22871      +13     
- Partials     2698     2703       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@agaudreault agaudreault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crenshaw-dev crenshaw-dev merged commit acb47b4 into argoproj:master Jan 3, 2025
28 checks passed
@crenshaw-dev crenshaw-dev deleted the major-version-bump-script branch January 3, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants