-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add script to bump major version #21363
chore: add script to bump major version #21363
Conversation
Signed-off-by: Michael Crenshaw <[email protected]>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #21363 +/- ##
==========================================
- Coverage 55.20% 55.17% -0.04%
==========================================
Files 337 337
Lines 57057 57057
==========================================
- Hits 31501 31483 -18
- Misses 22858 22871 +13
- Partials 2698 2703 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The PR for bumping major versions touches hundreds of files. To ease the review process, I want a script we can run and be confident that the only changes are the ones made by the script.
I've validated the script by running it locally, then running codegen, lint, and unit tests.
You can see an example of the generated PR here: crenshaw-dev#30