Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable increment-decrement from revive #21366

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

mmorel-35
Copy link
Contributor

Description

increment-decrement: By convention, for better readability, incrementing an integer variable by 1 is recommended to be done using the ++ operator. This rule spots expressions like i += 1 and i -= 1 and proposes to change them into i++ and i--.

@mmorel-35 mmorel-35 requested a review from a team as a code owner January 3, 2025 21:33
Copy link

bunnyshell bot commented Jan 3, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@mmorel-35 mmorel-35 force-pushed the revive/increment-decrement branch from 0c1dcb9 to 04233c5 Compare January 3, 2025 21:57
@crenshaw-dev crenshaw-dev enabled auto-merge (squash) January 3, 2025 22:03
@crenshaw-dev crenshaw-dev merged commit 4e5db16 into argoproj:master Jan 3, 2025
26 checks passed
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.22%. Comparing base (acb47b4) to head (04233c5).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21366      +/-   ##
==========================================
+ Coverage   55.20%   55.22%   +0.02%     
==========================================
  Files         337      337              
  Lines       57057    57057              
==========================================
+ Hits        31499    31511      +12     
+ Misses      22865    22850      -15     
- Partials     2693     2696       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmorel-35 mmorel-35 deleted the revive/increment-decrement branch January 3, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants