Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): Fix application url for custom base href #21377

Merged
merged 1 commit into from
Jan 16, 2025
Merged

fix(ui): Fix application url for custom base href #21377

merged 1 commit into from
Jan 16, 2025

Conversation

amit-o
Copy link
Contributor

@amit-o amit-o commented Jan 5, 2025 •
edited
Loading

The fix in #20004 was overwritten by 68606c6, so this PR fixes that.

Would appreciate cherry picking in 2.13 if possible.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@amit-o amit-o requested a review from a team as a code owner January 5, 2025 13:55
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Jan 5, 2025 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@amit-o amit-o changed the title fix(ui) - Fix application url for custom base href fix(ui): Fix application url for custom base href Jan 5, 2025
nitishfy
nitishfy approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@amit-o
Copy link
Contributor Author

amit-o commented Jan 12, 2025

Thanks @nitishfy , anyone we can ping for a final review?

@ishitasequeira ishitasequeira merged commit 3f0a155 into argoproj:master Jan 16, 2025
24 of 25 checks passed
@ishitasequeira
Copy link
Member

/cherry-pick release-2.13

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jan 16, 2025
@amit-o
Fix application url for custom base href (#21377)
4d52628 
Signed-off-by: Amit Oren <[email protected]>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Jan 16, 2025
Merged
@ishitasequeira
Copy link
Member

/cherry-pick release-2.14

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jan 16, 2025
@amit-o
Fix application url for custom base href (#21377)
20b89f8 
Signed-off-by: Amit Oren <[email protected]>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Jan 16, 2025
Merged
ishitasequeira pushed a commit that referenced this pull request Jan 16, 2025
@gcp-cherry-pick-bot @amit-o
Fix application url for custom base href (#21377) (#21515)
49163b0 
Signed-off-by: Amit Oren <[email protected]>
Co-authored-by: Amit Oren <[email protected]>
ishitasequeira pushed a commit that referenced this pull request Jan 16, 2025
@gcp-cherry-pick-bot @amit-o
Fix application url for custom base href (#21377) (#21516)
2bf5dc6 
Signed-off-by: Amit Oren <[email protected]>
Co-authored-by: Amit Oren <[email protected]>
@amit-o amit-o deleted the fix/app-url-prefix branch January 16, 2025 10:11
dudo pushed a commit to dudo/argo-cd that referenced this pull request Jan 18, 2025
@amit-o @dudo
Fix application url for custom base href (argoproj#21377)
53ff916 
Signed-off-by: Amit Oren <[email protected]>
Signed-off-by: Brett C. Dudo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitishfy nitishfy nitishfy approved these changes

@ishitasequeira ishitasequeira ishitasequeira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amit-o @ishitasequeira @nitishfy