Skip to content

Commit

Permalink
fix: update during setWeight: 100 could cause 503 errors
Browse files Browse the repository at this point in the history
  • Loading branch information
Abhishek Bansal committed Nov 4, 2024
1 parent fda1eba commit 94a03ad
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion rollout/trafficrouting.go
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ func (c *rolloutContext) reconcileTrafficRouting() error {
}
}

if !c.checkReplicasAvailable(c.stableRS, 100-desiredWeight) {
if !c.checkReplicasAvailable(c.stableRS, weightutil.MaxTrafficWeight(c.rollout)-desiredWeight) {
return nil
}
// We need to check for revision > 1 because when we first install the rollout we run step 0 this prevents that.
Expand Down

0 comments on commit 94a03ad

Please sign in to comment.