Skip to content

Commit

Permalink
Improve Documentation for Scaledown on Aborted Rollout
Browse files Browse the repository at this point in the history 
Improves understanding of how scaling down behaves depending on different configurations.
 • Canary with traffic routing + setCanaryScale does not scales down immediately when `abortScaleDownDelaySeconds = 0`.
 • Canary with traffic routing + setCanaryScale scales down after some delay of N second `abortScaleDownDelaySeconds = N`.
  • Loading branch information
@bishalthapa-t
bishalthapa-t committed Sep 17, 2024
1 parent 0e05ef7 commit bcfd6af
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions docs/features/scaledown-aborted-rs.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,15 @@ The following table summarizes the behavior under combinations of rollout strate
`abortScaleDownDelaySeconds = nil` is the default, which means in v1.1 across all rollout strategies, the new replicaset
is scaled down in 30 seconds on abort by default.

| strategy | v1.0 behavior | abortScaleDownDelaySeconds | v1.1 behavior |
|--------------------------------------------:|:-----------------------------:|:--------------------------:|:-----------------------------:|
| blue-green | does not scale down | nil | scales down after 30 seconds |
| blue-green | does not scale down | 0 | does not scale down |
| blue-green | does not scale down | N | scales down after N seconds |
| basic canary | rolling update back to stable | N/A | rolling update back to stable |
| canary w/ traffic routing | scales down immediately | nil | scales down after 30 seconds |
| canary w/ traffic routing | scales down immediately | 0 | scales down immediately |
| canary w/ traffic routing | scales down immediately | N | scales down immediately |
| strategy | v1.0 behavior | abortScaleDownDelaySeconds | v1.1 behavior |
|--------------------------------------------:|:-----------------------------:|:--------------------------:|:---------------------------------------------:|
| blue-green | does not scale down | nil | scales down after 30 seconds |
| blue-green | does not scale down | 0 | does not scale down |
| blue-green | does not scale down | N | scales down after N seconds |
| basic canary | rolling update back to stable | N/A | rolling update back to stable |
| canary w/ traffic routing | scales down immediately | nil | scales down after 30 seconds |
| canary w/ traffic routing | scales down immediately | 0 | scales down immediately |
| canary w/ traffic routing | scales down immediately | N | scales down immediately |
| canary w/ traffic routing + setCanaryScale | scales down immediately | 0 | does not scale down |
| canary w/ traffic routing + setCanaryScale | scales down immediately | N | scales down after N seconds |
| canary w/ traffic routing + setCanaryScale | does not scale down (bug) | * | should behave like canary w/ traffic routing |
| canary w/ traffic routing + setCanaryScale | does not scale down (bug) | * | should behave like canary w/ traffic routing |

0 comments on commit bcfd6af

Please sign in to comment.