Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: print error message in message field inside status in rollouts … #3932

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Abhish2702
Copy link

@Abhish2702 Abhish2702 commented Nov 5, 2024

Enhancement: Improved Error Reporting in Rollouts Controller

This PR introduces an enhancement to the rollouts controller, allowing it to record reconciliation error messages directly in the status field of Rollout objects.

Benefits:

Enhanced User Experience: Users can now view error messages associated with a Rollout object directly in its status, eliminating the need to search through the controller logs for debugging purposes.
Faster Issue Resolution: By surfacing errors in the status field, users can identify and address issues more efficiently, streamlining the troubleshooting process.

This enhancement is aimed at improving the overall usability and developer experience while working with Rollout objects.
Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Published E2E Test Results

  4 files    4 suites   7h 34m 27s ⏱️
113 tests  97 ✅  7 💤   9 ❌
664 runs  401 ✅ 28 💤 235 ❌

For more details on these failures, see this check.

Results for commit 83fd67b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Published Unit Test Results

2 280 tests   2 280 ✅  2m 59s ⏱️
  128 suites      0 💤
    1 files        0 ❌

Results for commit 83fd67b.

♻️ This comment has been updated with latest results.

@zachaller zachaller self-requested a review December 4, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant