Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Prometheus Metrics Provider Should Evaluate Prometheus Query Before Sending to Prometheus #4004

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

liesenfeldn
Copy link

@liesenfeldn liesenfeldn commented Dec 13, 2024

This relates to this issue.

I also set up a local kind cluster and tested this. I checked that this works with the templates we are attempting to create, but also i tested some of our old templates to make sure it is backwards compatible.

I mentioned some alternative implementations of this feature in my issue. Specifically i wanted to call out that we could also add a new field called QueryExpression or something similar, that way the Query behavior stays exactly as is, and this features get added in a new field in the struct.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@liesenfeldn liesenfeldn changed the title Enhancement: Prometheus Metrics Provider Should Evaluate Prometheus Query Before Sending to Prometheus featt: Prometheus Metrics Provider Should Evaluate Prometheus Query Before Sending to Prometheus Dec 13, 2024
@liesenfeldn liesenfeldn changed the title featt: Prometheus Metrics Provider Should Evaluate Prometheus Query Before Sending to Prometheus feat: Prometheus Metrics Provider Should Evaluate Prometheus Query Before Sending to Prometheus Dec 13, 2024
Copy link
Contributor

github-actions bot commented Dec 13, 2024

Published E2E Test Results

  4 files    4 suites   3h 9m 15s ⏱️
113 tests 101 ✅  7 💤 5 ❌
462 runs  425 ✅ 28 💤 9 ❌

For more details on these failures, see this check.

Results for commit f4b7bf2.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 13, 2024

Published Unit Test Results

2 298 tests   2 298 ✅  2m 59s ⏱️
  128 suites      0 💤
    1 files        0 ❌

Results for commit f4b7bf2.

♻️ This comment has been updated with latest results.

@liesenfeldn
Copy link
Author

I've checked off the My builds are green. Try syncing with master if they are not. part, because it says all checks have passed, but i'm not sure that was correct, since above it does link to this which indicated e2e test failures. Can someone help me understand this? Thanks!

@liesenfeldn liesenfeldn force-pushed the liesenfeldn/eval-query-before-running branch from 1f624fc to f4b7bf2 Compare December 19, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant