-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Prometheus Metrics Provider Should Evaluate Prometheus Query Before Sending to Prometheus #4004
base: master
Are you sure you want to change the base?
feat: Prometheus Metrics Provider Should Evaluate Prometheus Query Before Sending to Prometheus #4004
Conversation
…uery Signed-off-by: nliesenfeld <[email protected]>
…uery Signed-off-by: nliesenfeld <[email protected]>
Published E2E Test Results 4 files 4 suites 3h 9m 15s ⏱️ For more details on these failures, see this check. Results for commit f4b7bf2. ♻️ This comment has been updated with latest results. |
Published Unit Test Results2 298 tests 2 298 ✅ 2m 59s ⏱️ Results for commit f4b7bf2. ♻️ This comment has been updated with latest results. |
…uery Signed-off-by: nliesenfeld <[email protected]>
I've checked off the |
1f624fc
to
f4b7bf2
Compare
Quality Gate passedIssues Measures |
This relates to this issue.
I also set up a local kind cluster and tested this. I checked that this works with the templates we are attempting to create, but also i tested some of our old templates to make sure it is backwards compatible.
I mentioned some alternative implementations of this feature in my issue. Specifically i wanted to call out that we could also add a new field called
QueryExpression
or something similar, that way theQuery
behavior stays exactly as is, and this features get added in a new field in the struct.Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.