-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Love and Care #4
Open
dmgolembiowski
wants to merge
41
commits into
arirawr:master
Choose a base branch
from
dmgolembiowski:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trieve Grookey instead :P
…o be a fast lookup tool -- and since moves are usually the thing people care about -- I'll be making the entirety of moves available for Gen 8
…under one common flat file
… so in such a way that we get enum-slices from the responses, may prove to cause some headaches when it comes time to fully integrate the moves library with the main binary.
…y their move_id in the corresponding moves file
error[E0599]: no method named found for struct in the current scope Even though it definitely exists...
error[E0599]: no method named found for struct in the current scope Even though it definitely exists...
…so build in the TRs and Egg moves
currently fails on the \`let trs = <...>.into_iter().map(|mv| mv.into_move()).collect();\` despite working on the other types I implemented the trait for.
Recklessly merging upstream files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @arirawr,
I liked your work on this so much that I wanted to flesh out some more of your ideas (like the fuzzy searching) and getting new Gen-8 data. This is a pretty good start to getting the Pokedex of our dreams.
A good way to explore what I'm doing with the Pokedex data is to explore it on a Python REPL using