changes so the client are only made on init and with name changes #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makeecat
approved these changes
Jan 26, 2025
| double yaw = ui_->yaw_doubleSpinBox_gt->value(); | ||
|
|
||
| boost::mutex::scoped_lock lock(frame_updates_mutex_); | ||
| std::string srvs_name;// = "/"+ robot_name+"/"+mav_node_name+"/goTo"; |
There was a problem hiding this comment.
we can remove srvs_name string declaration
remove std_srvs declariations string as it is unneeded
mrunaljsarvaiya
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We changed it so clients aren't made on push button or in wait. We need to test in real world simulation looks fine.