Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

337 add xodr for environment example #340

Merged
merged 5 commits into from
Feb 3, 2025

Conversation

ClemensLinnhoff
Copy link
Collaborator

Describe your changes

Add examples of OpenDRIVE, OpenSCENARIO and OSI

Issue ticket number and link

Fixes #337

Checklist before requesting a review

  • I have performed a self-review of my code/documentation.
  • My changes generate no new warnings during the documentation generation.

@ClemensLinnhoff
Copy link
Collaborator Author

@LudwigFriedmann you asked about the OpenDRIVE file for the environment example. I thought it might be beneficial to also have a corresponding OpenSCENARIO file as an example. And while I was at it, I also added an OSI trace file, so we can showcase all interactions between all relevant ASAM standards.

What do you think?

Copy link
Member

@AsamDiegoSanchez AsamDiegoSanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed.
Signed-Off by: Diego Sánchez [email protected]

examples/scenario_example/README.md Outdated Show resolved Hide resolved
Signed-off-by: FKlopfer <[email protected]>
Signed-off-by: Clemens <[email protected]>
@ClemensLinnhoff
Copy link
Collaborator Author

@LudwigFriedmann could you review this?

Copy link
Collaborator

@LudwigFriedmann LudwigFriedmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly!

@LudwigFriedmann
Copy link
Collaborator

The PR can be merged right away. We could even use screenshots for the documentation:
OpenDRIVE_BB
Environment_BB
Environment_Vehicle

Signed-off-by: ClemensLinnhoff <[email protected]>
@ClemensLinnhoff
Copy link
Collaborator Author

The PR can be merged right away. We could even use screenshots for the documentation.

Thanks, I added the screenshots to the Readme.

@ClemensLinnhoff ClemensLinnhoff merged commit f6f5a59 into main Feb 3, 2025
3 checks passed
@ClemensLinnhoff ClemensLinnhoff deleted the 337-add-xodr-for-environment-example branch February 3, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add xodr for environment example
4 participants