Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Chapter 4: Backwards compatibility #255

Closed
AsamDiegoSanchez opened this issue Dec 18, 2024 · 6 comments · Fixed by #304
Closed

Fix Chapter 4: Backwards compatibility #255

AsamDiegoSanchez opened this issue Dec 18, 2024 · 6 comments · Fixed by #304
Assignees
Labels
isType:Editorial An issue that contains general structural and editorial changes
Milestone

Comments

@AsamDiegoSanchez
Copy link
Member

Describe the bug
It is currently empty

Expected behavior
When no earlier version of the standard exists, add the following content to this section (see in Editorial Guide: 2.1.7 Backward compatibility):

"This is the first release of this standard published by ASAM.
Therefore, no information about the backward compatibility of this standard has been added to this section."

@AsamDiegoSanchez AsamDiegoSanchez added the isType:Editorial An issue that contains general structural and editorial changes label Dec 18, 2024
@AsamDiegoSanchez AsamDiegoSanchez added this to the v1.0.0 milestone Dec 18, 2024
@mettelilienthal
Copy link
Collaborator

Added to my branch Complete-linguistic-review :) I will commit my changes soon.

@ClemensLinnhoff
Copy link
Collaborator

@mettelilienthal when you create the pull request for your linguistic review, please make sure to add all issues that are addressed by that in the PR. Best practice is to use the "fixes" keyword, so in this case "fixes #255". Then this issue will be automatically closed, when the PR is merged.

@ClemensLinnhoff
Copy link
Collaborator

@mettelilienthal When are you planning to merge your branch "Complete-linguistic-review"? It is now 58 commits behind the main branch.
As you said this will addresses multiple issues and I would like to get an overview, over which issues are still open.

@FKlopfer
Copy link
Collaborator

We are planning to merge the branch by the end of this week so the native speaker review can start on Monday. It will deal with the remaing editorial issues that are assigned to us: #272, #260, #255.

@ClemensLinnhoff
Copy link
Collaborator

Thanks for the information. What about #128?

@FKlopfer
Copy link
Collaborator

We have that on our list but it will not be part of the "Complete-linguistic-review" branch. We plan to finish that next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
isType:Editorial An issue that contains general structural and editorial changes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants