Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete linguistic review #304

Merged
merged 22 commits into from
Jan 21, 2025
Merged

Complete linguistic review #304

merged 22 commits into from
Jan 21, 2025

Conversation

mettelilienthal
Copy link
Collaborator

@mettelilienthal mettelilienthal commented Jan 17, 2025

Describe your changes

Add a description of the changes proposed in the pull request.

Some questions to ask:

  • What is the change?
  • What does it fix?
  • Is this a bug fix or a feature? Does it break any existing functionality or force me to update to a new version?
  • How has it been tested?

Issue ticket number and link

fixes #255, #260, #272

Mention a member

Add @mentions of the person or team responsible for reviewing the proposed changes.

Checklist before requesting a review

  • I have performed a self-review of my code/documentation.
  • My changes generate no new warnings during the documentation generation.

Signed-off-by: FKlopfer <[email protected]>
@FKlopfer FKlopfer marked this pull request as ready for review January 20, 2025 13:58
@FKlopfer
Copy link
Collaborator

@ClemensLinnhoff , @AsamDiegoSanchez , please review and merge.

Signed-off-by: FKlopfer <[email protected]>
@ClemensLinnhoff
Copy link
Collaborator

Please add to the PR description, which issues are solved by this. Currently it only says #255 but it fixes more than that.

content/general-docs/introduction.adoc Show resolved Hide resolved
content/general-docs/introduction.adoc Outdated Show resolved Hide resolved
content/geometry/general.adoc Outdated Show resolved Hide resolved
content/geometry/introduction.adoc Outdated Show resolved Hide resolved
content/geometry/introduction.adoc Outdated Show resolved Hide resolved
schemas/mapping_schema.json Outdated Show resolved Hide resolved
schemas/material_brdf_schema.json Outdated Show resolved Hide resolved
Signed-off-by: FKlopfer <[email protected]>
Signed-off-by: FKlopfer <[email protected]>
Signed-off-by: FKlopfer <[email protected]>
@FKlopfer
Copy link
Collaborator

@ClemensLinnhoff , I incorporated your feedback, please check.

@ClemensLinnhoff
Copy link
Collaborator

Please add to the PR description, which issues are solved by this. Currently it only says #255 but it fixes more than that.

Please add the issues

@ClemensLinnhoff ClemensLinnhoff self-requested a review January 21, 2025 10:51
Copy link
Collaborator

@ClemensLinnhoff ClemensLinnhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After adding the missing issues to the PR description, this can be merged.

@FKlopfer
Copy link
Collaborator

Ah, I only added them in the sidebar, not the description. Done now.

@FKlopfer FKlopfer merged commit d339a4a into main Jan 21, 2025
4 checks passed
@FKlopfer FKlopfer deleted the Complete-linguistic-review branch January 21, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants