-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete linguistic review #304
Conversation
Linguistic review (merge main into branch)
Signed-off-by: FKlopfer <[email protected]>
Signed-off-by: FKlopfer <[email protected]>
@ClemensLinnhoff , @AsamDiegoSanchez , please review and merge. |
Signed-off-by: FKlopfer <[email protected]>
Please add to the PR description, which issues are solved by this. Currently it only says #255 but it fixes more than that. |
Signed-off-by: FKlopfer <[email protected]>
Signed-off-by: FKlopfer <[email protected]>
Signed-off-by: FKlopfer <[email protected]>
Signed-off-by: FKlopfer <[email protected]>
@ClemensLinnhoff , I incorporated your feedback, please check. |
Please add the issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After adding the missing issues to the PR description, this can be merged.
Ah, I only added them in the sidebar, not the description. Done now. |
Describe your changes
Add a description of the changes proposed in the pull request.
Some questions to ask:
Issue ticket number and link
fixes #255, #260, #272
Mention a member
Add @mentions of the person or team responsible for reviewing the proposed changes.
Checklist before requesting a review