Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Human structure #38

Merged
merged 11 commits into from
Aug 26, 2024
Merged

Human structure #38

merged 11 commits into from
Aug 26, 2024

Conversation

FKlopfer
Copy link
Collaborator

@FKlopfer FKlopfer commented Jul 18, 2024

Add initial content for human structure

  • Added the adoc files for the chapter about the human structure in the geometry subgroup.
  • There is an index files that orders the adoc files.
  • Every adoc file contains some default content.

Fixes #1

@FKlopfer
Copy link
Collaborator Author

@mettelilienthal , please review.

@mettelilienthal
Copy link
Collaborator

@LudwigFriedmann please review :)

content/geometry/human-index.adoc Outdated Show resolved Hide resolved
content/geometry/human-structure/Hip_(T).adoc Outdated Show resolved Hide resolved
content/geometry/human-index.adoc Outdated Show resolved Hide resolved
content/geometry/human-index.adoc Outdated Show resolved Hide resolved
content/geometry/human-index.adoc Outdated Show resolved Hide resolved
content/geometry/human-index.adoc Outdated Show resolved Hide resolved
content/geometry/human-index.adoc Outdated Show resolved Hide resolved
content/geometry/human-index.adoc Outdated Show resolved Hide resolved
Copy link
Collaborator

@LudwigFriedmann LudwigFriedmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to integrate the model structure in an overarching document, I'd extend the table of content by the chapters "Introduction", "General" and "Model Creation":

|- Introduction
|- General
|- Model Creation
|- Model Structure
| |- ... current toc content ...
|- Notes

@FKlopfer
Copy link
Collaborator Author

FKlopfer commented Aug 1, 2024

Note: If all three PR are merged into main (vehicle, human, road), I will also adapt the index file. There will be no index files for the subchapters (human, vehicle etc.) but only one index file for geometry.

Signed-off-by: FabianKlopfer <[email protected]>
@ClemensLinnhoff
Copy link
Collaborator

Note: If all three PR are merged into main (vehicle, human, road), I will also adapt the index file. There will be no index files for the subchapters (human, vehicle etc.) but only one index file for geometry.

I propose to merge #36 first, then merge main into this branch and directly index the files correctly into the chapter structure.

@FKlopfer
Copy link
Collaborator Author

FKlopfer commented Aug 1, 2024

Note: If all three PR are merged into main (vehicle, human, road), I will also adapt the index file. There will be no index files for the subchapters (human, vehicle etc.) but only one index file for geometry.

I propose to merge #36 first, then merge main into this branch and directly index the files correctly into the chapter structure.

Agreed, we can do it this way.

@ClemensLinnhoff ClemensLinnhoff marked this pull request as draft August 2, 2024 04:59
@LudwigFriedmann
Copy link
Collaborator

The table of content seems to be removed from this chapter. As it serves as visualization of the hierarchical structure, can we have it back?

@ClemensLinnhoff
Copy link
Collaborator

The table of content seems to be removed from this chapter. As it serves as visualization of the hierarchical structure, can we have it back?

@nakohdo please process the same way as described here: #35 (comment)

@ClemensLinnhoff
Copy link
Collaborator

This should fix #1 so I added it to the PR description.

@ClemensLinnhoff
Copy link
Collaborator

@mettelilienthal see #35 (comment)

@ClemensLinnhoff
Copy link
Collaborator

I fixed adjusted the file structure analog to the vehicle structure. @mettelilienthal please fix the hierarchy visualization as described in #77.

@mettelilienthal
Copy link
Collaborator

@ClemensLinnhoff @LudwigFriedmann I've added the hierarchy levels.

Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
@ClemensLinnhoff
Copy link
Collaborator

@LudwigFriedmann Could you review this? I would like to merge soon, to check the visualization. Then create new issues from there.

@ClemensLinnhoff ClemensLinnhoff marked this pull request as ready for review August 26, 2024 09:50
@ClemensLinnhoff ClemensLinnhoff dismissed LudwigFriedmann’s stale review August 26, 2024 10:48

Let's merge this as is and create new issues for things that need to be adjusted.

@ClemensLinnhoff ClemensLinnhoff merged commit 28033ac into main Aug 26, 2024
1 check passed
@ClemensLinnhoff ClemensLinnhoff deleted the human-structure branch August 26, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Origin of the pedestrian structure not well defined
4 participants