Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates #701

Merged
merged 21 commits into from
Jan 9, 2024
Merged

Minor updates #701

merged 21 commits into from
Jan 9, 2024

Conversation

Goooler
Copy link
Contributor

@Goooler Goooler commented Jan 9, 2024

We can kick these things by enabling @renovate-bot and keep this repo up to date.

renovate bot and others added 20 commits January 9, 2024 10:32
* chore(deps): update actions/checkout action to v4

* Remove workaround

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Goooler <[email protected]>
@Goooler
Copy link
Contributor Author

Goooler commented Jan 9, 2024

I'm trying to upgrade Gradle 8 for this project, will send a PR after finishing that.

@ysb33r
Copy link
Member

ysb33r commented Jan 9, 2024

I'm trying to upgrade Gradle 8 for this project, will send a PR after finishing that.

If you can get it to work, great, but the requirement is that the plugin suite has to compatible with a minimum of Gradle 7.0.2

@ysb33r ysb33r merged commit 196dd88 into asciidoctor:development-4.x Jan 9, 2024
3 checks passed
@Goooler
Copy link
Contributor Author

Goooler commented Jan 9, 2024

I bumped it to Gradle 7.6 first, but 1 test failed, I'm not sure why, see

@ysb33r
Copy link
Member

ysb33r commented Jan 9, 2024

I bumped it to Gradle 7.6 first, but 1 test failed, I'm not sure why, see

* [Gradle 7.6.3 Goooler/asciidoctor-gradle-plugin#43](https://github.com/Goooler/asciidoctor-gradle-plugin/pull/43)

* https://scans.gradle.com/s/pebpcysnv2ne6/tests/overview?outcome=FAILED

It probably has to do with how properties are interpreted. If you change the 'Can generate a asciidoctorconfigfile' test in AsciidoctorEditorConfigIntegrationSpec to rather contain the following, I think it will work

        attrFile.text = ":${key3}: ${value3}\n"

        new File(projectDir,'gradle.properties').text = """
        group=${groupName}
        version=${projVer}
        """.stripIndent()
        
        getGroovyBuildFile("""
        apply plugin : 'org.asciidoctor.jvm.base'

@Goooler
Copy link
Contributor Author

Goooler commented Jan 9, 2024

It works! Addressing the update to #704.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants