Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix doc publication job #708

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Fix doc publication job #708

merged 1 commit into from
Jan 11, 2024

Conversation

Goooler
Copy link
Contributor

@Goooler Goooler commented Jan 11, 2024

@aalmiray aalmiray merged commit 01733d2 into asciidoctor:master Jan 11, 2024
3 checks passed
@aalmiray
Copy link
Member

Thanks!

@Goooler Goooler deleted the master branch January 11, 2024 16:55
@abelsromero
Copy link
Member

The build failed, I think it's because since we use multi-line run: | we need to add \ to chain the arguments?

@Goooler
Copy link
Contributor Author

Goooler commented Jan 11, 2024

Ooooops, forgot that. Please do.

@abelsromero
Copy link
Member

abelsromero commented Jan 11, 2024 •
edited
Loading

Ooooops, forgot that. Please do.

No problem, feel free to send another PR. If you feel paranoid, you should be able to test in your fork.

edit: I think it's late in your timezone, this can wait, no hurry.

@aalmiray
Copy link
Member

Strange. I went ahead with the merge as I saw a green build

@abelsromero abelsromero mentioned this pull request Feb 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Goooler @aalmiray @abelsromero