-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Xero Provider #547
Comments
You should be able to use the Pull Requests to add other providers as a fairly good guide of what's required to add a new provider. |
I made a good start on this last night, I could get Authenticated but then I discovered that all the User information is packaged in a JWT. This has caused some further complication. I believe the SuperOffice implementation is similar so I may start again with that as a template. Any suggestions for working with JWT's? |
The Apple and SuperOffice providers both deal with JWTs, but the SuperOffice provider is more recent so has the preferred approach for dealing with them IIRC in terms of JWT. |
@martincostello, hello. |
If you take a look at the Apple and SuperOffice tests, you'll find expired JWTs in the them. The expiry checks are then disabled in the tests (or the clock frozen) so they don't expire. You can either construct them by hand/with code, or capture a token from a real request and use/modify that, as long as there's nothing truly sensitive encoded in it. |
@martincostello, created PR #649 |
Fiddler logs
|
Is your feature request related to a problem? Please describe.
Xero.com uses OAuth 2.0 it would be great to have a provider for this service.
Describe the solution you'd like
Add a new provider for Xero.com
Documentation: https://developer.xero.com/documentation/oauth2/sign-in
Would be happy to contribute to this solution with a bit of guidance.
The text was updated successfully, but these errors were encountered: