Xero provider #649
Merged
Xero provider #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
There was a problem hiding this comment.
This looks good - thanks @serber!
Just some minor comments.
src/AspNet.Security.OAuth.Xero/AspNet.Security.OAuth.Xero.csproj
Outdated
Show resolved
Hide resolved
Co-authored-by: Martin Costello <[email protected]>
martincostello
approved these changes
Jan 26, 2022
|
@serber Are you planning on submitting any more PRs soon? If so I'll wait for those before publishing this provider (which otherwise I'll probably do this weekend) so we can batch them all up into a single 6.0.4 release, rather than having a lot in quick succession. |
|
@martincostello, I plan to take #597 and #542 in next 1-2 week |
|
Awesome - in that case I'll wait for the other two before publishing the new providers to NuGet.org as there's no other changes currently planned to go out. If that changes I'll let you know. I'll merge this for now, it can be consumed from our MyGet preview feed until the final 6.0.4 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created provider for https://xero.com