Skip to content
This repository has been archived by the owner on Oct 6, 2023. It is now read-only.

Assap/dev resize #51

Merged
merged 4 commits into from
Nov 28, 2019
Merged

Assap/dev resize #51

merged 4 commits into from
Nov 28, 2019

Conversation

jorcuad
Copy link
Collaborator

@jorcuad jorcuad commented Nov 28, 2019

PR Details

New side menu created and component conections refactor.

Description

Now the subcomponents are all in the home component and are using signals to comunicate between them.

Also the right menu has been added and it is ready to be populated with the options.

Related Issue

#44

Motivation and Context

The refactor is required in order to grow the application. The menu is needed to configure the facial identification.

How Has This Been Tested

Manual testing.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • [ X ] New feature (non-breaking change which adds functionality)
  • [ X ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [ X ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [ X ] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jiep jiep changed the base branch from master to assap/dev November 28, 2019 17:57
@RuthGnz RuthGnz merged commit d46b10b into assap/dev Nov 28, 2019
@nereasainzdelamaza nereasainzdelamaza deleted the assap/dev_resize branch November 29, 2019 17:40
@jorcuad jorcuad added the enhancement New feature or request label Nov 29, 2019
@jorcuad jorcuad added this to the Cybercamp 2019 milestone Nov 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants