Remove box shadows from Reveal.js slides #229
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case it was added through custom CSS. Keeping it create an oversized PDF.
|
Thanks for the PR. To make sure we are not breaking intended usage of box shadows, are these styles coming from RevealJS default CSS? What version of RevealJS do you use? |
|
No, it's not coming from default CSS of RevealJS. This is similar to 33b0975 |
|
If not accepted because not default CSS, I understand. Then #191 would be great. |
|
Right. I'd rather rely on #191 for custom CSS. We could add an option to the CLI so that users can provide their custom CSS patch, and have it inserted like in this PR, but rather in the main loop so that it benefits to all the presentation frameworks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case it was added through custom CSS.
Keeping box-shadow creates a heavy PDF file.