ENH: adding async mode to IRSA TAP based queries #3201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
query_tap
andquery_region
has the newasync_mode
bool kwarg.I was testing with the query listed in astropy/pyvo#629 which times out with the sync mode, but works as expected and fast! with async. I don't really understand why this latter behaviour, but it doesn't matter much either as we leave it to the user to decide which mode to use rather than building in a heuristic in astroquery.
Closes #3143
Prior discussion about changing the API approach from the duplication of methods and favouring a keyword based future: #2598