Patching some of the issues with hierarchy navigation #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sswaitUS
requested review from
tjacovich,
danielchivvis,
katieefrey and
BartlettAstro
sswaitUS
commented
Jan 29, 2025
| @@ -224,7 +258,11 @@ | |||
| <strong>Narrower Concepts:</strong> | |||
| <ul> | |||
| {% for n in element.narrower %} | |||
| <li class="uat"><a href="{{n.uri[30:]}}?view={{gtype}}{% if path %}&path={{path|last}}{% endif %}">{{n.name}}</a></li> | |||
| <li class="uat"> | |||
| <a href="{{n.uri[30:]}}?view={{gtype}}{% if path %}&path={{path|last}}-{{element.uri[30:]}}{% else %}&path={{element.uri[30:]}}{% endif %}"> | |||
There was a problem hiding this comment.
This was missing the element in the path so I added it
sswaitUS
commented
Jan 29, 2025
| @@ -211,11 +234,22 @@ | |||
|
|
|||
| <br/> | |||
|
|
|||
| {% if element.broader != None %} | |||
| {% if element.broader != None and element.broader|length < 2 %} | |||
There was a problem hiding this comment.
If there is only 1 Broader Concept, will just use the previous path to avoid the lookup of other paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hierarchy navigation is not reflected when a concept (broader, narrow or related) is clicked for a particular concept. Issue was due to always using the same path as the current concept to be reflected in the hierarchy, which is not where they exist