Few checks on the code

aswinvk28 · Nov 29, 2016 · 51e24f6 · 51e24f6
1 parent 4f17498
commit 51e24f6
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/snmpload.py b/snmpload.py
@@ -12,32 +12,31 @@
 net = Mininet(SingleSwitchTopo(2))
 
 def mininet_start_nodes(net):
-    validated = false
+    validated = False
     net.start()
     pingResults = net.pingAll()
     if(pingResults.find('100% dropped') & pingResults.find('100.0')):
-        validated = true 
+        validated = True
     if(validated):
         return net.values()
     return 0
 
 
 def mininet_snmp_load(host, community, objectID):
     g = getCmd(SnmpEngine(),
-            CommunityData('public'),
-            UdpTransportTarget(('demo.snmplabs.com', 161)),
+            CommunityData(community),
+            UdpTransportTarget((host, 161)),
             ContextData(),
-            ObjectType(ObjectIdentity('SNMPv2-MIB', 'sysDescr', 0)))
-
-    next(g)
+            ObjectType(ObjectIdentity('SNMPv2-MIB', objectID, 0)))
 
 nodes = mininet_start_nodes(net)
 if(nodes):
     for node in nodes:
-        print ""
+        mininet_snmp_load(node, community='public', objectID='sysDesc')
 
 
 
 
 
-net.stop()
+net.stop()
+sys.exit(0)
diff --git a/topology.py b/topology.py
@@ -13,7 +13,8 @@
 
 while 1:
     data = connection.recv(1024)
-    if not data break
+    if (data != NULL):
+        break
     list = data.split("\t")
     mininetSNMPValues = mininet_snmp_load(list[0], list[1], list[2]) # returns a dictionary
     connection.send(str(mininetSNMPValues))