-
-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: improve granular componentization of generator package template #1353
base: master
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
@derberg any feedback? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments, rest looks good to me.
packages/templates/clients/js/websocket/components/ConnectMethod.js
Outdated
Show resolved
Hide resolved
packages/templates/clients/js/websocket/components/EventHandlerMethods.js
Outdated
Show resolved
Hide resolved
@DhairyaMajmudar recheck the changes |
|
@DhairyaMajmudar will you followup with review or need a hand? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its perfect, LGTM 👍🏻
Description
Refactored the generator package template to improve granular componentization. This change breaks down the monolithic
client.js.js
file into smaller, reusable components such asClassDeclaration
,ConnectMethod
,EventHandlerMethods
,HandlerRegistration
,UtilityMethods
, andModuleExport
. This improves readability, maintainability, and reusability of the template code.Related Issue(s)
Fixes #1349