Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix manage_file_capabilities #3

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Fix manage_file_capabilities #3

merged 2 commits into from
Oct 20, 2022

Conversation

jeffbyrnes
Copy link
Member

@jeffbyrnes jeffbyrnes commented Oct 20, 2022 •
edited
Loading

SUMMARY

Fixes a bug where $manage_file_capabilities is true and $package_name is a custom name (i.e., not 'vault')

See jsok#157

TESTS/SPECS

Add a context to test a custom package name when $manage_file_capabilities = true

@b3n4kh @jeffbyrnes
Fix manage_file_capabilities
424743c 
Fixes a bug where $manage_file_capabilities is true and $package_name
is a custom name (i.e., not 'vault')
@jeffbyrnes jeffbyrnes added the bug Something isn't working label Oct 20, 2022
@jeffbyrnes jeffbyrnes requested a review from DLeich October 20, 2022 19:52
@jeffbyrnes jeffbyrnes self-assigned this Oct 20, 2022
@jeffbyrnes jeffbyrnes marked this pull request as ready for review October 20, 2022 20:07
@jeffbyrnes jeffbyrnes merged commit 4aab895 into main Oct 20, 2022
@jeffbyrnes jeffbyrnes deleted the manage_file_capabilities_fix branch October 20, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DLeich DLeich Awaiting requested review from DLeich

Assignees

@jeffbyrnes jeffbyrnes

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffbyrnes @b3n4kh