Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle tag inheritance #29

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Handle tag inheritance #29

wants to merge 2 commits into from

Conversation

gscano
Copy link
Contributor

@gscano gscano commented Jul 16, 2020

This is an attempt at solving #24 based on the org-use-tag-inheritance and org-tags-exclude-from-inheritance variables.

Inherited tags are recursively listed up to the #+:FILETAGS keyword before being filtered according to those two variables, while headline tags are always added. The order in which the tags appear in the CSV column respects the hierarchy, with file level tags first and headline level tags last.

Additional coverage tests are provided.

Thanks in advance for your review!

@Wheest
Copy link

Wheest commented Jun 3, 2021

I had lost this PR in my inbox, but I recently returned to org-csv and experienced this issue again

I'm glad to see that you got something working, thanks!

I have tried running this code in a standalone machine, and found that it exhibited the expected behaviour.

Reviewing the code, everything LGTM. I believe it needs updated to fix the merge conflict, I will review if this is done.

@dapritchard
Copy link

Hi all, thanks for all your efforts regarding this incredibly useful package.

I have a branch at https://github.com/dapritchard/org-clock-csv/tree/merge-issue/24 that performs the merge to bring this PR into the master branch. Is there any way that my branch could be used to enable the merge in this repository? What would be the right protocol for me to do here, perhaps submit a PR to @gscano's branch?

As an aside, I also added a commit to add the STARTED TODO keyword to the issue-23.org file. It appears that in my version of Emacs (v27.2) STARTED is not one of the default keywords, and this was causing the test-issue-23 test to fail for me. I'm happy to raise this as a separate issue, if desired.

@gscano
Copy link
Contributor Author

gscano commented Sep 17, 2021

Hi David,

thank you for taking the time to solve this merge conflict! No need for a PR, I pushed your commit directly.

I also experienced the problem with the TODO keyword in master and you solved it. Since the tests do not pass on issue/24 I would suggest a PR on master to first solve the tests there.

@dapritchard
Copy link

Excellent! As per the suggestion, I've created a new issue #31 and associated PR #32 to handle the test-issue-23 TODO keywords issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants