[AXON-40] fix: add slightly more graceful failures in JiraIssuePage #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdzh-atlassian
requested review from
bwieger-atlassian-com and
cabella-dot
as code owners
sdzh-atlassian
force-pushed
the
AXON-40-field-ui-type-workaround
branch
from
923e61f to
2ccd070
Compare
cabella-dot
previously approved these changes
Dec 18, 2024
sdzh-atlassian
force-pushed
the
AXON-40-field-ui-type-workaround
branch
from
2ccd070 to
cf567e4
Compare
Add temporary workaround to have JiraIssuePage fail slightly more gracefully if a field is missing and we can't render markup for it
sdzh-atlassian
force-pushed
the
AXON-40-field-ui-type-workaround
branch
from
cf567e4 to
1a868b1
Compare
sdzh-atlassian
commented
Dec 18, 2024
bwieger-atlassian-com
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
A temporary workaround to put into
nightlyso that we can hopefully dig a little deeper into #46With this, if we try to render markup for an
undefinedfield - we skip rendering that field, and we get an error message:Some considerations on this:
JiraIssuePagewhich could fail with that exact step should beSummary- but that feels impossible?How was this tested?
undefined as any, saw the error message and the page without the fields