pipewire: Revise plugin code. Closes: #1401 #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
radioactiveman
commented
Nov 29, 2024
radioactiveman
commented
- Use RingBuf from audcore
- Respect output_buffer_size setting
- Improve get_delay() and drain() functions
- Add support for 5 and 7 channels
|
@jlindgren90: Is this looking good for you? Especially the implementation of @maris-ab: I have found https://docs.pipewire.org/structpw__time.html in the PipeWire docs. I'm not sure though if/how this could be used to determine the delay. Maybe @wtay as PipeWire author can support here? |
jlindgren90
reviewed
Nov 29, 2024
radioactiveman
force-pushed
the
master
branch
2 times, most recently
from
185ddd3 to
f14fe1e
Compare
- Use RingBuf from audcore - Respect output_buffer_size setting - Improve get_delay() and drain() functions - Add support for 5 and 7 channels Co-authored-by: Thomas Lange <[email protected]>
|
Looking very nice. @radioactiveman any idea why the CI build fails on Ubuntu 22.04? |
radioactiveman
force-pushed
the
master
branch
from
f14fe1e to
8ae758b
Compare
radioactiveman
commented
Dec 1, 2024
The pipeline is green now. I needed to add version checks and fallback methods for Ubuntu 22.04. |
jlindgren90
approved these changes
Dec 1, 2024
radioactiveman
merged commit fedb27c
into
audacious-media-player:master
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.