Skip to content

Commit

Permalink
to simplify PR, remove other shellcheck-driven comments & changes
Browse files Browse the repository at this point in the history
  • Loading branch information
mobilemind committed Jun 23, 2017
1 parent 6281ea2 commit 195a13c
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions rmate
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,6 @@ function hostname_command(){
fi
}

# intent is to execute hostname command, so disable the warning
# shellcheck disable=SC2091
hostname=$($(hostname_command))

# default configuration
Expand All @@ -79,8 +77,6 @@ function load_config {
fi
}

# "home" is from earlier eval so disable warning about unassigned reference
# shellcheck disable=SC2154
for i in "/etc/${0##*/}" $home/."${0##*/}/${0##*/}.rc" $home/."${0##*/}.rc"; do
load_config "$i"
done
Expand Down Expand Up @@ -296,8 +292,6 @@ function open_file {
fi

if [ "$filepath" != "-" ] && [ -f "$filepath" ]; then
# ls is used to get filesize, so skip warning about find
# shellcheck disable=SC2012
filesize=`ls -lLn "$realpath" | awk '{print $5}'`
echo "data: $filesize" 1>&3
cat "$realpath" 1>&3
Expand Down Expand Up @@ -389,8 +383,6 @@ function handle_connection {
#
exec 3<> "/dev/tcp/$host/$port"

# checking return value of exec here is clearer; skip warning
# shellcheck disable=SC2181
if [ $? -gt 0 ]; then
echo "Unable to connect to TextMate on $host:$port"
exit 1
Expand Down

0 comments on commit 195a13c

Please sign in to comment.