Revert incomplete fix of configspace index order in pdp and symb. expl.

automl · Feb 9, 2024 · 208ebfa · 208ebfa
1 parent ab0164a
commit 208ebfa
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 9 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -15,7 +15,6 @@
 - Fix api examples (#68).
 - Reset inputs to fix error when subsequently selecting runs with different configspaces, objectives or budgets (#106).
 - Fix errors due to changing inputs before runselection (#64).
-- Fix varying configspace index order in PDP and symbolic explanations.
 
 # Version 1.1.3
 

diff --git a/deepcave/plugins/hyperparameter/pdp.py b/deepcave/plugins/hyperparameter/pdp.py
@@ -191,10 +191,6 @@ def process(run, inputs):
         surrogate_model = RandomForestSurrogate(run.configspace, seed=0)
         surrogate_model.fit(X, Y)
 
-        # This is necessary as the run configspace can differ from the surrogate, which would be problematic as the
-        # surrogate configspace is used in the PDP and the run configspace for plotting in load_outputs()
-        surrogate_model.config_space = run.configspace
-
         # Prepare the hyperparameters
         selected_hyperparameters = [hp1]
         if hp2 is not None and hp2 != "":

diff --git a/deepcave/plugins/hyperparameter/symbolic_explanations.py b/deepcave/plugins/hyperparameter/symbolic_explanations.py
@@ -266,10 +266,6 @@ def process(run, inputs):
         surrogate_model = RandomForestSurrogate(run.configspace, seed=0)
         surrogate_model.fit(X, Y)
 
-        # This is necessary as the run configspace can differ from the surrogate, which would be problematic as the
-        # surrogate configspace is used in the PDP and the run configspace for plotting in load_outputs()
-        surrogate_model.config_space = run.configspace
-
         # Prepare the hyperparameters
         selected_hyperparameters = [hp1]
         idx1 = run.configspace.get_idx_by_hyperparameter_name(hp1)