Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_vehicle_info_utils): porting from universe to core #183

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

NorahXiong
Copy link
Contributor

Description

We are porting autoware_vehicle_info_utils to autoware.core, and this PR adds the package to core.

Issue Link #131

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Copy link

github-actions bot commented Feb 7, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@liuXinGangChina
Copy link
Contributor

mits san and kondo san @mitsudome-r @youtalk

Since Kang is still having his holiday, We close the original pr and create this new pr which include the modification that mits san required today.

Best regards

心刚

mitsudome-r
mitsudome-r previously approved these changes Feb 7, 2025
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 55.44554% with 45 lines in your changes missing coverage. Please review.

Project coverage is 71.68%. Comparing base (4cb18f5) to head (ce1c84e).
Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
...n/autoware_vehicle_info_utils/src/vehicle_info.cpp 54.34% 18 Missing and 3 partials ⚠️
...ehicle_info_utils/test/test_vehicle_info_utils.cpp 40.62% 0 Missing and 19 partials ⚠️
...ware_vehicle_info_utils/src/vehicle_info_utils.cpp 77.27% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
- Coverage   78.75%   71.68%   -7.08%     
==========================================
  Files          11       14       +3     
  Lines         193      279      +86     
  Branches       73      118      +45     
==========================================
+ Hits          152      200      +48     
- Misses         11       31      +20     
- Partials       30       48      +18     
Flag Coverage Δ *Carryforward flag
differential 55.44% <55.44%> (?)
total 80.89% <ø> (+2.14%) ⬆️ Carriedforward from b5be19d

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mitsudome-r mitsudome-r dismissed their stale review February 12, 2025 07:44

needs another review

@mitsudome-r mitsudome-r self-requested a review February 12, 2025 07:44
@mitsudome-r
Copy link
Member

I get errors when I try to build this with Autoware.Universe.
It seems like the modifications for changing autoware_universe_utils to autoware_utils functions are causing errors in dependent packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants