Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_probabilistic_occupancy_grid_map): improved data handling on the ogm #10060

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

knzo25
Copy link
Contributor

@knzo25 knzo25 commented Jan 31, 2025

Description

Through a better use of the data and streams, this PR decreases the processing time from 8ms to 4ms when using the full concatenated pointcloud

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

…ated pointcloud the processing time decreases from 8ms to 4ms

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jan 31, 2025
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@knzo25
Copy link
Contributor Author

knzo25 commented Jan 31, 2025

The increase in time was product of the following PR:
autowarefoundation/autoware_launch#1319

@YoshiRi

@knzo25 knzo25 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 31, 2025
@knzo25 knzo25 self-assigned this Jan 31, 2025
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 0% with 49 lines in your changes missing coverage. Please review.

Project coverage is 29.04%. Comparing base (461dbc1) to head (e9e8140).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
...d_map/pointcloud_based_occupancy_grid_map_node.cpp 0.00% 26 Missing ⚠️
...istic_occupancy_grid_map/utils/cuda_pointcloud.hpp 0.00% 13 Missing ⚠️
...rid_map/lib/costmap_2d/occupancy_grid_map_base.cpp 0.00% 9 Missing ⚠️
...id_map/lib/updater/binary_bayes_filter_updater.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10060      +/-   ##
==========================================
- Coverage   29.21%   29.04%   -0.17%     
==========================================
  Files        1439     1441       +2     
  Lines      108115   108169      +54     
  Branches    42638    42618      -20     
==========================================
- Hits        31588    31421     -167     
- Misses      73485    73708     +223     
+ Partials     3042     3040       -2     
Flag Coverage Δ *Carryforward flag
differential-cuda 0.00% <0.00%> (?)
total 29.13% <ø> (-0.09%) ⬇️ Carriedforward from 461dbc1

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

1 participant