Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_tensorrt_yolox): fix clang-diagnostic-inconsistent-missing-override #9512

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

kobayu858
Copy link
Contributor

Description

This is a fix based on clang-tidy clang-diagnostic-inconsistent-missing-override error.

are/src/universe/autoware.universe/perception/autoware_tensorrt_yolox/include/autoware/tensorrt_yolox/calibrator.hpp:251:10: error: 'getQuantile' overrides a member function but is not marked 'override' [clang-diagnostic-inconsistent-missing-override]
  double getQuantile() const noexcept
         ^
/usr/include/x86_64-linux-gnu/NvInfer.h:8412:20: note: overridden virtual function is here
    virtual double getQuantile() const noexcept = 0;
                   ^
/home/emb4/autoware/autoware/src/universe/autoware.universe/perception/autoware_tensorrt_yolox/include/autoware/tensorrt_yolox/calibrator.hpp:257:10: error: 'getRegressionCutoff' overrides a member function but is not marked 'override' [clang-diagnostic-inconsistent-missing-override]
  double getRegressionCutoff(void) const noexcept
         ^
/usr/include/x86_64-linux-gnu/NvInfer.h:8420:20: note: overridden virtual function is here
    virtual double getRegressionCutoff() const noexcept = 0;
                   ^
/home/emb4/autoware/autoware/src/universe/autoware.universe/perception/autoware_tensorrt_yolox/include/autoware/tensorrt_yolox/calibrator.hpp:263:16: error: 'readHistogramCache' overrides a member function but is not marked 'override' [clang-diagnostic-inconsistent-missing-override]
  const void * readHistogramCache(std::size_t & length) noexcept
               ^
/usr/include/x86_64-linux-gnu/NvInfer.h:8434:25: note: overridden virtual function is here
    virtual void const* readHistogramCache(std::size_t& length) noexcept = 0;
                        ^
/home/emb4/autoware/autoware/src/universe/autoware.universe/perception/autoware_tensorrt_yolox/include/autoware/tensorrt_yolox/calibrator.hpp:282:8: error: 'writeHistogramCache' overrides a member function but is not marked 'override' [clang-diagnostic-inconsistent-missing-override]
  void writeHistogramCache(void const * ptr, std::size_t length) noexcept
       ^
/usr/include/x86_64-linux-gnu/NvInfer.h:8444:18: note: overridden virtual function is here
    virtual void writeHistogramCache(void const* ptr, std::size_t length) noexcept = 0;
                 ^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:require-cuda-build-and-test labels Nov 28, 2024
Copy link

github-actions bot commented Nov 28, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kobayu858 kobayu858 requested a review from veqcc November 28, 2024 08:30
@kobayu858 kobayu858 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 28, 2024
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 29.51%. Comparing base (c1bbd68) to head (87069f8).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...lox/include/autoware/tensorrt_yolox/calibrator.hpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9512      +/-   ##
==========================================
+ Coverage   29.47%   29.51%   +0.03%     
==========================================
  Files        1440     1439       -1     
  Lines      108556   108364     -192     
  Branches    41499    41418      -81     
==========================================
- Hits        32001    31982      -19     
+ Misses      73443    73277     -166     
+ Partials     3112     3105       -7     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 29.51% <ø> (+0.03%) ⬆️ Carriedforward from 2fbacc7

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kobayu858 kobayu858 enabled auto-merge (squash) November 28, 2024 10:41
@kobayu858 kobayu858 disabled auto-merge November 28, 2024 10:41
@kobayu858 kobayu858 merged commit fdc7a55 into autowarefoundation:main Nov 28, 2024
32 checks passed
@kobayu858 kobayu858 deleted the clang-tidy-pe49 branch December 9, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) tag:require-cuda-build-and-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants