-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docker): re-organize the autoware docker containers #4072
Changes from all commits
f82c50c
b1ffd10
8c18629
1718ce9
041e00e
6f85cdd
20d4a28
3ce272f
26e72c3
5ff919e
c77dd04
83c88b9
70d844e
66f2552
3df3bf9
09811ae
fe9a840
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
FROM ghcr.io/autowarefoundation/autoware-openadk:latest-devel | ||
|
||
ENV SHELL /bin/bash | ||
|
||
ARG USERNAME=autoware | ||
ARG USER_UID=1000 | ||
ARG USER_GID=$USER_UID | ||
|
||
RUN groupadd --gid $USER_GID $USERNAME \ | ||
&& useradd --uid $USER_UID --gid $USER_GID -m $USERNAME \ | ||
&& apt-get update \ | ||
&& apt-get install -y sudo \ | ||
&& echo $USERNAME ALL=\(root\) NOPASSWD:ALL > /etc/sudoers.d/$USERNAME \ | ||
&& chmod 0440 /etc/sudoers.d/$USERNAME |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
{ | ||
"name": "Autoware", | ||
"build": { | ||
"dockerfile": "Dockerfile" | ||
}, | ||
"remoteUser": "autoware", | ||
"hostRequirements": { | ||
"gpu": true | ||
}, | ||
"runArgs": [ | ||
"--cap-add=SYS_PTRACE", | ||
"--security-opt", | ||
"seccomp=unconfined", | ||
"--net=host", | ||
"--volume=/etc/localtime:/etc/localtime:ro" | ||
Check warning on line 15 in .devcontainer/base/devcontainer.json
|
||
], | ||
"customizations": { | ||
"vscode": { | ||
"settings.json": { | ||
"terminal.integrated.profiles.linux": { "bash": { "path": "/bin/bash" } } | ||
} | ||
} | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
FROM ghcr.io/autowarefoundation/autoware-openadk:latest-devel-cuda | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If apart from this line the rest of the file is exactly the same as in base/Dockerfile then I think it would be better to keep a single Dockerfile under .devcontainer/ and instead have an There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @oguzkaganozt will look into this tomorrow in a follow up PR. Let's merge this as it is today. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ok |
||
|
||
ENV SHELL /bin/bash | ||
|
||
ARG USERNAME=autoware | ||
ARG USER_UID=1000 | ||
ARG USER_GID=$USER_UID | ||
|
||
RUN groupadd --gid $USER_GID $USERNAME \ | ||
&& useradd --uid $USER_UID --gid $USER_GID -m $USERNAME \ | ||
&& apt-get update \ | ||
&& apt-get install -y sudo \ | ||
&& echo $USERNAME ALL=\(root\) NOPASSWD:ALL > /etc/sudoers.d/$USERNAME \ | ||
&& chmod 0440 /etc/sudoers.d/$USERNAME |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
{ | ||
"name": "Autoware-cuda", | ||
"build": { | ||
"dockerfile": "Dockerfile" | ||
}, | ||
"remoteUser": "autoware", | ||
"hostRequirements": { | ||
"gpu": true | ||
}, | ||
"runArgs": [ | ||
"--cap-add=SYS_PTRACE", | ||
"--security-opt", | ||
"seccomp=unconfined", | ||
"--net=host", | ||
"--volume=/etc/localtime:/etc/localtime:ro", | ||
Check warning on line 15 in .devcontainer/cuda/devcontainer.json
|
||
"--gpus", | ||
"all" | ||
], | ||
"customizations": { | ||
"vscode": { | ||
"settings.json": { | ||
"terminal.integrated.profiles.linux": { "bash": { "path": "/bin/bash" } } | ||
} | ||
} | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
# Ignore git and metadata directories | ||
.git | ||
.github | ||
.vscode | ||
|
||
# Ignore all markdown files | ||
*.md | ||
|
||
# Ignore Docker files | ||
docker-bake.hcl | ||
|
||
# Etc | ||
*.ignore | ||
*.lint | ||
*.lock | ||
*.log | ||
*.out |
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be removed for this non-GPU file. Although it is not critical because if I remember correctly it just issues a warning in the logs, but doesn't block anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolving following #4072 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not good at VSCode with Containers, I don't know if this affects anything related to RViz. If you think we can remove it safely, I can remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It won't change how things get setup. From https://containers.dev/implementors/json_reference/#min-host-reqs: "you will be presented with a warning if the requirements are not met". Removing this won't affect whether rviz works or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ambroise-arm I see, I will let @oguzkaganozt know this, let's remove it as well in the next PR.