Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docker): add simulator-visualizer container #5411

Closed
wants to merge 36 commits into from
Closed

feat(docker): add simulator-visualizer container #5411

wants to merge 36 commits into from

Conversation

oguzkaganozt
Copy link
Contributor

@oguzkaganozt oguzkaganozt commented Nov 7, 2024 •
edited
Loading

Description

To enable full development and deployment with containers, a dedicated simulator-visualizer container will be beneficial. This container will include the Tier IV Scenario Simulator, RViz Plugins, all necessary ROS 2 message definitions.

Additionally, it will support VNC and NoVNC so users can visualize the RViz screen remotely.

Tests performed

https://github.com/autowarefoundation/autoware/actions/runs/13057452157/job/36431979397?pr=5411

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@oguzkaganozt oguzkaganozt added type:containers Docker containers, containerization of components, or container orchestration. component:openadkit Issues or Features related to Open AD Kit labels Nov 7, 2024
@oguzkaganozt oguzkaganozt self-assigned this Nov 7, 2024
@oguzkaganozt oguzkaganozt marked this pull request as ready for review November 7, 2024 12:50
@oguzkaganozt oguzkaganozt requested a review from youtalk as a code owner November 7, 2024 12:50
@oguzkaganozt oguzkaganozt marked this pull request as draft November 7, 2024 12:51
@oguzkaganozt oguzkaganozt force-pushed the openadkit-simulator-visualizer branch 5 times, most recently from c0afed8 to 637d735 Compare November 25, 2024 09:11
@oguzkaganozt oguzkaganozt force-pushed the openadkit-simulator-visualizer branch from 637d735 to f7337c8 Compare January 2, 2025 13:47
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@oguzkaganozt oguzkaganozt marked this pull request as ready for review January 2, 2025 13:48
youtalk
youtalk reviewed Jan 8, 2025
View reviewed changes
Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry for the delayed review.

.github/actions/docker-build-and-push/action.yaml Outdated Show resolved Hide resolved
.github/actions/docker-build-and-push/action.yaml Outdated Show resolved Hide resolved
docker/tools/Dockerfile Outdated Show resolved Hide resolved
@oguzkaganozt oguzkaganozt force-pushed the openadkit-simulator-visualizer branch from 79d8a6f to 4b9b35b Compare January 16, 2025 10:37
youtalk
youtalk reviewed Jan 16, 2025
View reviewed changes
docker/tools/Dockerfile Outdated Show resolved Hide resolved
@youtalk
Copy link
Member

youtalk commented Jan 17, 2025

Please fix the https://results.pre-commit.ci/run/github/41331761/1737026915.ReZe0rS_QaW-5f0MZ2o0mA error too.

@oguzkaganozt oguzkaganozt force-pushed the openadkit-simulator-visualizer branch from b8ffe3e to e2019be Compare January 30, 2025 07:17
@oguzkaganozt oguzkaganozt added the tag:run-health-check Run health-check label Jan 30, 2025
@oguzkaganozt oguzkaganozt force-pushed the openadkit-simulator-visualizer branch 2 times, most recently from a4ea4f0 to 2d6ee34 Compare February 4, 2025 13:57
@oguzkaganozt oguzkaganozt requested a review from youtalk February 4, 2025 17:32
@oguzkaganozt
Copy link
Contributor Author

@youtalk please review again.

youtalk
youtalk requested changes Feb 5, 2025
View reviewed changes
Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has become too large to review. Please split it into PRs for just the visualizer and just the scenario_simulator.

@oguzkaganozt
Add simulator and visualizer containers
16b24e7 
Signed-off-by: Oguz Ozturk <[email protected]>
@oguzkaganozt
.
1e95c85 
Signed-off-by: Oguz Ozturk <[email protected]>
@oguzkaganozt
.
3998648 
Signed-off-by: Oguz Ozturk <[email protected]>
oguzkaganozt and others added 26 commits February 6, 2025 14:47
@oguzkaganozt
.
e278a88 
Signed-off-by: Oguz Ozturk <[email protected]>
@oguzkaganozt
.
bcaf694 
Signed-off-by: Oguz Ozturk <[email protected]>
@oguzkaganozt
fix typo
87598f3 
Signed-off-by: Oguz Ozturk <[email protected]>
@oguzkaganozt
fix spellcheck
71baa41 
Signed-off-by: Oguz Ozturk <[email protected]>
@oguzkaganozt
fix spellcheck
1276ddd 
Signed-off-by: Oguz Ozturk <[email protected]>
@oguzkaganozt
.
18ea4d2 
Signed-off-by: Oguz Ozturk <[email protected]>
@oguzkaganozt
.
79b07e8 
Signed-off-by: Oguz Ozturk <[email protected]>
@oguzkaganozt
fix hadolint errors
985ed76 
Signed-off-by: Oguz Ozturk <[email protected]>
@oguzkaganozt
fix hadolint errors
b718346 
Signed-off-by: Oguz Ozturk <[email protected]>
@oguzkaganozt
.
2bf66df 
Signed-off-by: Oguz Ozturk <[email protected]>
@oguzkaganozt
.
aab257c 
Signed-off-by: Oguz Ozturk <[email protected]>
@oguzkaganozt
remove ngrok, remove VNC_PASSWORD ARG
38779bd 
Signed-off-by: Oguz Ozturk <[email protected]>
@oguzkaganozt
.
2dc2eb8 
Signed-off-by: Oguz Ozturk <[email protected]>
@pre-commit-ci @oguzkaganozt
style(pre-commit): autofix
d25f16c
@oguzkaganozt
.
3be0392 
Signed-off-by: Oguz Ozturk <[email protected]>
@pre-commit-ci @oguzkaganozt
style(pre-commit): autofix
3825f2d
@oguzkaganozt
.
50e9f6a 
Signed-off-by: Oguz Ozturk <[email protected]>
@oguzkaganozt
.
3bdc03c 
Signed-off-by: Oguz Ozturk <[email protected]>
@oguzkaganozt
fix rviz config
c079d73 
Signed-off-by: Oguz Ozturk <[email protected]>
@pre-commit-ci @oguzkaganozt
style(pre-commit): autofix
026d748
@oguzkaganozt
fix paths
dc7d645 
Signed-off-by: Oguz Ozturk <[email protected]>
@oguzkaganozt
remove .pcd from dockerignore
5dce48b 
Signed-off-by: Oguz Ozturk <[email protected]>
@oguzkaganozt
.
0f56b77 
Signed-off-by: Oguz Ozturk <[email protected]>
@oguzkaganozt
.
9d120e8 
Signed-off-by: Oguz Ozturk <[email protected]>
@oguzkaganozt
remove debug workflow
9236720 
Signed-off-by: Oguz Ozturk <[email protected]>
@oguzkaganozt
.
33ba71b 
Signed-off-by: Oguz Ozturk <[email protected]>
@oguzkaganozt oguzkaganozt force-pushed the openadkit-simulator-visualizer branch from 3a9f211 to 33ba71b Compare February 6, 2025 11:47
@oguzkaganozt
Copy link
Contributor Author

It has become too large to review. Please split it into PRs for just the visualizer and just the scenario_simulator.

@youtalk @mitsudome-r Please review

Scenario simulator: #5740
Visualizer: #5742

@oguzkaganozt
Copy link
Contributor Author

Splitted into two PRs: #5742 , #5740

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youtalk youtalk youtalk requested changes

@mitsudome-r mitsudome-r Awaiting requested review from mitsudome-r mitsudome-r is a code owner

@xmfcx xmfcx Awaiting requested review from xmfcx xmfcx is a code owner

Assignees

@oguzkaganozt oguzkaganozt

Labels
component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check type:containers Docker containers, containerization of components, or container orchestration.
Projects
Open AD Kit Working Group
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oguzkaganozt @youtalk