Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ansible/artifacts): add rtmdet onnx model #5605

Merged
merged 6 commits into from
Jan 26, 2025

Conversation

StepTurtle
Copy link
Contributor

Description

This PR adds some Ansible tasks to download tensorrt rtmdet model.

Related Links

How was this PR tested?

Notes for reviewers

None.

Effects on system behavior

None.

Copy link

github-actions bot commented Dec 23, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@StepTurtle
Copy link
Contributor Author

@xmfcx Can you review this PR?

@xmfcx
Copy link
Contributor

xmfcx commented Dec 23, 2024

Could you pass pre-commit-ci checks?

@StepTurtle
Copy link
Contributor Author

StepTurtle commented Dec 24, 2024

Could you pass pre-commit-ci checks?

@xmfcx All checks are OK now.

Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some small suggestions, thanks for the PR🐝!

@xmfcx xmfcx force-pushed the feat/rtmdet_model branch from 9ab3e84 to d5e7b3b Compare January 26, 2025 20:53
Signed-off-by: M. Fatih Cırıt <[email protected]>
@xmfcx xmfcx added the tag:run-health-check Run health-check label Jan 26, 2025
Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

image

I've simplified it by using:

    extra_opts:
      - --strip-components=1

https://www.gnu.org/software/tar/manual/html_section/transform.html

Before:

  • extract
  • move
  • delete the top level folder

Now:

  • extract

We have 2 less ansible steps. And if you run it multiple times, it shows no modifications ✅.

@xmfcx xmfcx merged commit 627ecef into autowarefoundation:main Jan 26, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:run-health-check Run health-check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants