-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ansible/artifacts): add rtmdet onnx model #5605
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
@xmfcx Can you review this PR? |
Could you pass pre-commit-ci checks? |
@xmfcx All checks are OK now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added some small suggestions, thanks for the PR🐝!
Signed-off-by: Barış Zeren <[email protected]>
Signed-off-by: Barış Zeren <[email protected]>
Signed-off-by: Barış Zeren <[email protected]>
9ab3e84
to
d5e7b3b
Compare
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've simplified it by using:
extra_opts:
- --strip-components=1
https://www.gnu.org/software/tar/manual/html_section/transform.html
Before:
- extract
- move
- delete the top level folder
Now:
- extract
We have 2 less ansible steps. And if you run it multiple times, it shows no modifications ✅.
Description
This PR adds some Ansible tasks to download tensorrt rtmdet model.
Related Links
How was this PR tested?
Notes for reviewers
None.
Effects on system behavior
None.