Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add simulator and tools nightly repos #5755

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Feb 7, 2025

Description

When building with combination autoware-nightly.repos and tools.repos, the following error occurs. So add tools-nightly.repos to use the corresponding tools version when using autoware-nightly. Same for simulator.repos so I add an empty file.

/home/isamutakagi/workspace/awf/autoware/repo/src/tools/planning/autoware_static_centerline_generator/src/type_alias.hpp:42:7: error: ‘tier4_planning_msgs’ has not been declared
   42 | using tier4_planning_msgs::msg::PathWithLaneId;

How was this PR tested?

Check if the build passes when using *-nightly.repos files.

Notes for reviewers

None.

Effects on system behavior

None.

Copy link

github-actions bot commented Feb 7, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Collaborator

@sasakisasaki sasakisasaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick Comment

Thank you for applying this fix!

Reason for Approval

This PR intends to fix the error which is related to msg's update (tier4_xxx_msgs => autoware_xxx_msgs). The corresponding repositories which are using the latest autoware.universe (main) need to follow the msg's update. In my understanding, this PR provides the *-nightly.repos files to let the corresponding repositories follow the latest update in the autoware.universe.

The performed test looks enough to me. Thus, I agree with merge this PR 👍

@mitsudome-r mitsudome-r merged commit e373393 into autowarefoundation:main Feb 7, 2025
19 checks passed
@isamu-takagi isamu-takagi deleted the feat/add-tools-and-simulator-nightly-repos branch February 7, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants