feat(lanelet2_map_validator): apply version control to lanelet2_map_validator #208
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR provides lanelet2_map_validator a versioning structure.
This PR does the following.
package.xml
package.xml
to the share directory to read the package version.autoware_requirement_set.json
validation
tag to the.osm
file that describes the map is validated by "what validator" with "what validator version" reflecting "what kind of map requirements" with "what requirement version".lanelet2_map_validator
.How was this PR tested?
1. Checked that general usage works fine with the new versioning feature
The following command works fine.
AND one can find a
validation
tag like this in the osm file.2. Checked that
colcon test
works fineThe following command works fine.
colcon test --packages-select autoware_lanelet2_map_validator --event-handlers console_cohesion+
Notes for reviewers
I also wanted to put information whether the validation passed or not, but it requires to change the structure of
process_requirements
function. I will do that later and do not add this feature here.Effects on system behavior
None.