function definitions updated in thruster_interface #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulknnns
reviewed
Mar 2, 2024
rahulknnns
reviewed
Mar 2, 2024
| @@ -20,8 +20,7 @@ class Communication { | |||
|
|
|||
| void sendOrientation(Vec3f orientation); | |||
| void sendIMURawData(Vec3i accelerometer, Vec3i gyroscope, Vec3i magnetometer); | |||
| void sendIMUData(Vec3f acceleration, Vec3f angular_velocity, | |||
| Vec3f magnetic_field); | |||
| void sendIMUData(Vec3f acceleration, Vec3f angular_velocity, Vec3f magnetic_field); | |||
There was a problem hiding this comment.
Use clang formatter, Function signature is too big to be written in a single line
rahulknnns
reviewed
Mar 2, 2024
| */ | ||
|
|
||
| void Thrusters::setPWMs(const int32_t pwm_values[kThrusterCount]) { | ||
|
|
There was a problem hiding this comment.
What will happen if wrong values are being Sent?
rahulknnns
requested changes
Mar 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thruster pin numbers configured
kThrusterCount value updated
functions defined and signatures modified
Documentation for the functions added