Swap out Bash based APT query logic for Golang version. #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: apt cache performance Use a single call to apt-cache to reduce the time needed to lookup package versions. Also: * Added millisecond details to log timing so slow operations can be more easily identified. * Perform apt update before determining package versions. Fixes #103 * chore: descriptive variable names and use log_err Added the review feedback, updating variable names to be more descriptive and using log_err where appropriate.
* Pull dev upstream to staging. (#112) * Use awk to enclose filename in single quotes tar #99 * Add null field separator so filenames don't get broken up. * Move upload logs up in the action sequence so it captures data before it gets deleted. * Fix awk (#109) --------- Co-authored-by: sn-o-w <[email protected]> * Fix awk delimiter. Pull in fix by @sn-o-w in https://github.com/sn-o-w/cache-apt-pkgs-action/commit/d0ee83b497ac30023e51cd526c62e57b07501912 mentioned in issue #99 --------- Co-authored-by: sn-o-w <[email protected]>
awalsh128
added a commit
that referenced
this pull request
Dec 22, 2023
) * Pull dev upstream to staging. (#112) * Use awk to enclose filename in single quotes tar #99 * Add null field separator so filenames don't get broken up. * Move upload logs up in the action sequence so it captures data before it gets deleted. * Fix awk (#109) --------- Co-authored-by: sn-o-w <[email protected]> * Fix awk delimiter. Pull in fix by @sn-o-w in https://github.com/sn-o-w/cache-apt-pkgs-action/commit/d0ee83b497ac30023e51cd526c62e57b07501912 mentioned in issue #99 * Swap out Bash based APT query logic for Golang version. (#117) * First version of a Golang version of command handling in general. (#118) --------- Co-authored-by: sn-o-w <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String parsing and state management has been rather cumbersome when fetching APT package data (exemplified in solution to #106). Decided to use Golang since it provide basic data structures, succinct array operations and better error handling. If this pans out, might rewrite the entire action in Go.