LibWeb: Use correct factory function when cloning a Document node

Cloning an XMLDocument should produce a new XMLDocument. Same for HTMLDocument. This fixes at least one WPT test, which we're also importing. :^)
awesomekling · Nov 19, 2024 · 98b1df6 · 98b1df6
1 parent 24a6fd3
commit 98b1df6
Show file tree

Hide file tree

Showing 3 changed files with 51 additions and 1 deletion.
diff --git a/Libraries/LibWeb/DOM/Node.cpp b/Libraries/LibWeb/DOM/Node.cpp
@@ -32,8 +32,10 @@
 #include <LibWeb/DOM/Range.h>
 #include <LibWeb/DOM/ShadowRoot.h>
 #include <LibWeb/DOM/StaticNodeList.h>
+#include <LibWeb/DOM/XMLDocument.h>
 #include <LibWeb/HTML/CustomElements/CustomElementReactionNames.h>
 #include <LibWeb/HTML/HTMLAnchorElement.h>
+#include <LibWeb/HTML/HTMLDocument.h>
 #include <LibWeb/HTML/HTMLImageElement.h>
 #include <LibWeb/HTML/HTMLInputElement.h>
 #include <LibWeb/HTML/HTMLSelectElement.h>
@@ -1021,7 +1023,16 @@ WebIDL::ExceptionOr<GC::Ref<Node>> Node::clone_node(Document* document, bool clo
     else if (is<Document>(this)) {
         // Document
         auto document_ = verify_cast<Document>(this);
-        auto document_copy = Document::create(this->realm(), document_->url());
+        auto document_copy = [&] -> GC::Ref<Document> {
+            switch (document_->document_type()) {
+            case Document::Type::XML:
+                return XMLDocument::create(realm(), document_->url());
+            case Document::Type::HTML:
+                return HTML::HTMLDocument::create(realm(), document_->url());
+            default:
+                return Document::create(realm(), document_->url());
+            }
+        }();
 
         // Set copy’s encoding, content type, URL, origin, type, and mode to those of node.
         document_copy->set_encoding(document_->encoding());

diff --git a/Tests/LibWeb/Text/expected/wpt-import/dom/nodes/Node-cloneNode-XMLDocument.txt b/Tests/LibWeb/Text/expected/wpt-import/dom/nodes/Node-cloneNode-XMLDocument.txt
@@ -0,0 +1,11 @@
+Summary
+
+Harness status: OK
+
+Rerun
+
+Found 1 tests
+
+1 Pass
+Details
+Result	Test Name	MessagePass	Created with createDocument	
diff --git a/Tests/LibWeb/Text/input/wpt-import/dom/nodes/Node-cloneNode-XMLDocument.html b/Tests/LibWeb/Text/input/wpt-import/dom/nodes/Node-cloneNode-XMLDocument.html
@@ -0,0 +1,28 @@
+<!DOCTYPE html>
+<meta charset="utf-8">
+<title>Cloning of an XMLDocument</title>
+<link rel="help" href="https://dom.spec.whatwg.org/#dom-node-clonenode">
+<link rel="help" href="https://dom.spec.whatwg.org/#concept-node-clone">
+
+<!-- This is testing in particular "that implements the same interfaces as node" -->
+
+<script src="../../resources/testharness.js"></script>
+<script src="../../resources/testharnessreport.js"></script>
+
+<script>
+"use strict";
+
+test(() => {
+  const doc = document.implementation.createDocument("namespace", "");
+
+  assert_equals(
+    doc.constructor, XMLDocument,
+    "Precondition check: document.implementation.createDocument() creates an XMLDocument"
+  );
+
+  const clone = doc.cloneNode(true);
+
+  assert_equals(clone.constructor, XMLDocument);
+}, "Created with createDocument");
+
+</script>