pin amplify-category-api to 5.12.10 #14116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolk
reviewed
Feb 21, 2025
There was a problem hiding this comment.
The ^ in amplify-category-api is intentional.
When we build CLI release we're using a version from yarn.lock. Which currently points 5.12.10.
The purpose of ^ is that when jobs in category-api repo install cli-internal then the cli is compatible with any new version of category-api. So that you can run cli with category api release that is about to ship.
If you need to pin category api in your e2e tests, that should be happening in category api repo, not here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Pin
amplify-category-apito5.12.10so that API Gen1 canaries and e2e install5.12.10and not5.13.0.Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.