[chore] Fix workflows with breaking changes and Set/modify otel propagators in the build scripts #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aneurysm9
reviewed
Dec 31, 2024
| @@ -9,4 +9,5 @@ popd || exit | |||
| # Build sample app | |||
|
|
|||
| cd ../opentelemetry-lambda/go/sample-apps/function || exit | |||
| go mod tidy | |||
There was a problem hiding this comment.
This should not be necessary. The repo shouldn't ever be left in a state where the go.mod file is inconsistent.
There was a problem hiding this comment.
i agree, created the PR, i will remove this line once the upstream pr is merged.
vasireddy99
changed the title
I have updated the description related to the changes. |
vasireddy99
changed the title
alexperez52
approved these changes
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates the scripts and make more changes w/r/t to the breaking changes after sub module update
go mod tidyto fix the inconsistent go mod file upstream.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.