Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add gitleaks in pre-commit hooks as an extra safety measure #2677

Conversation

step-security-bot
Copy link
Contributor

@step-security-bot step-security-bot commented Jul 5, 2023

Issue number: #2203

Summary

This pull request is created by Secure Repo at the request of @heitorlessa. Please merge the Pull Request to incorporate the requested changes. Please tag @heitorlessa on your message if you have any questions related to the PR. You can also engage with the StepSecurity team by tagging @step-security-bot.

Security Fixes

Keeping your actions up to date with Dependabot

With Dependabot version updates, when Dependabot identifies an outdated dependency, it raises a pull request to update the manifest to the latest version of the dependency. This is recommended by GitHub as well as The Open Source Security Foundation (OpenSSF).

Maintain Code Quality with Pre-Commit

Pre-commit is a framework for managing and maintaining multi-language pre-commit hooks. Hooks can be any scripts, code, or binaries that run at any stage of the git workflow. Pre-commit hooks are useful for enforcing code quality, code formatting, and detecting security vulnerabilities.

Feedback

For bug reports, feature requests, and general feedback; please create an issue in step-security/secure-repo. To create such PRs, please visit https://app.stepsecurity.io/securerepo.

Signed-off-by: StepSecurity Bot [email protected]

@step-security-bot step-security-bot requested a review from a team as a code owner July 5, 2023 10:10
@boring-cyborg boring-cyborg bot added github-actions Pull requests that update Github_actions code internal Maintenance changes labels Jul 5, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 5, 2023
@heitorlessa heitorlessa changed the title [StepSecurity] Apply security best practices chore(ci): add gitleaks in pre-commit hooks as an extra safety measure Jul 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

No acknowledgement section found. Please make sure you used the template to open a PR and didn't remove the acknowledgment section. Check the template here: https://github.com/aws-powertools/powertools-lambda-python/blob/develop/.github/PULL_REQUEST_TEMPLATE.md#acknowledgment

@github-actions github-actions bot added do-not-merge need-issue PRs that are missing related issues need-license-agreement-acknowledge PRs that are missing acknowledgement section labels Jul 5, 2023
.pre-commit-config.yaml Outdated Show resolved Hide resolved
@heitorlessa heitorlessa removed do-not-merge need-issue PRs that are missing related issues need-license-agreement-acknowledge PRs that are missing acknowledgement section labels Jul 5, 2023
@heitorlessa
Copy link
Contributor

@leandrodamascena I can't merge as I fixed an incorrect recommendation in the PR.

@varunsh-coder
Copy link

Thanks, @heitorlessa, for using the new pre-commit hook option. I have created an issue to track the pinning of revs in pre-commit hooks: step-security/secure-repo#2211.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-actions Pull requests that update Github_actions code internal Maintenance changes size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants