-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cloudfront): add validations on ResponseHeadersCorsBehavior.accessControlAllowMethods #32769
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Exemption Request Only validations are added and these are not covered by integration tests. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32769 +/- ##
=======================================
Coverage 81.37% 81.37%
=======================================
Files 222 222
Lines 13693 13693
Branches 2412 2412
=======================================
Hits 11143 11143
Misses 2271 2271
Partials 279 279
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing ✅ A exemption request has been requested. Please wait for a maintainer's review. |
Issue # (if applicable)
N/A
Reason for this change
There is no description about the allowed values on
ResponseHeadersPolicy
'scorsBehavior.accessControlAllowMethods
.The wildcard (any methods allowed) is
ALL
instead of*
(wildcard for headers).This PR adds the description and validations on it.
Description of changes
Added the description of the allowed values on
ResponseHeadersCorsBehavior.accessControlAllowMethods
.Added validations:
['ALL']
which means any http methods are allowedDescribe any new or updated permissions being added
Nothing
Description of how you validated changes
Added unit tests
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license