Add the required Accept header for RPCv2 (#5649)

aws · Oct 8, 2024 · 85857b5 · 85857b5
1 parent 0677684
commit 85857b5
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 2 deletions.
diff --git a/...n-protocol/src/main/java/software/amazon/awssdk/protocols/json/internal/ProtocolFact.java b/...n-protocol/src/main/java/software/amazon/awssdk/protocols/json/internal/ProtocolFact.java
@@ -53,7 +53,9 @@ public boolean generatesBody(OperationInfo info) {
      */
     ProtocolFact SMITHY_RPC_V2_CBOR = new ProtocolFact() {
         private final Map<String, String> extraHeaders = Collections.unmodifiableMap(MapUtils.of("smithy-protocol",
-                                                                                                 "rpc-v2-cbor"));
+                                                                                                 "rpc-v2-cbor",
+                                                                                                 "Accept",
+                                                                                                 "application/cbor"));
         /**
          * Smithy RPCv2 only skips body generation for operation without input defined. These operations mark themselves using
          * the {@link BaseAwsJsonProtocolFactory#GENERATES_BODY} metadata attribute. Otherwise, the protocol default is to

diff --git a/...e/src/main/resources/software/amazon/awssdk/protocol/suites/cases/smithy-rpcv2-input.json b/...e/src/main/resources/software/amazon/awssdk/protocol/suites/cases/smithy-rpcv2-input.json
@@ -20,6 +20,7 @@
                 "headers": {
                     "contains": {
                         "Content-Type": "application/cbor",
+                        "Accept": "application/cbor",
                         "smithy-protocol": "rpc-v2-cbor"
                     }
                 }
@@ -56,6 +57,7 @@
                 "headers": {
                     "contains": {
                         "Content-Type": "application/cbor",
+                        "Accept": "application/cbor",
                         "smithy-protocol": "rpc-v2-cbor"
                     }
                 }
@@ -88,6 +90,7 @@
                 "headers": {
                     "contains": {
                         "Content-Type": "application/cbor",
+                        "Accept": "application/cbor",
                         "smithy-protocol": "rpc-v2-cbor"
                     }
                 }
@@ -119,6 +122,7 @@
                 "headers": {
                     "contains": {
                         "Content-Type": "application/cbor",
+                        "Accept": "application/cbor",
                         "smithy-protocol": "rpc-v2-cbor"
                     }
                 }
@@ -149,6 +153,7 @@
                 "headers": {
                     "contains": {
                         "Content-Type": "application/cbor",
+                        "Accept": "application/cbor",
                         "smithy-protocol": "rpc-v2-cbor"
                     }
                 }
@@ -181,6 +186,7 @@
                 "headers": {
                     "contains": {
                         "Content-Type": "application/cbor",
+                        "Accept": "application/cbor",
                         "smithy-protocol": "rpc-v2-cbor"
                     }
                 }
@@ -211,6 +217,7 @@
                 "headers": {
                     "contains": {
                         "Content-Type": "application/cbor",
+                        "Accept": "application/cbor",
                         "smithy-protocol": "rpc-v2-cbor"
                     }
                 }
@@ -242,6 +249,7 @@
                 "headers": {
                     "contains": {
                         "Content-Type": "application/cbor",
+                        "Accept": "application/cbor",
                         "smithy-protocol": "rpc-v2-cbor"
                     }
                 }
@@ -318,6 +326,7 @@
                 "headers": {
                     "contains": {
                         "Content-Type": "application/cbor",
+                        "Accept": "application/cbor",
                         "smithy-protocol": "rpc-v2-cbor"
                     }
                 }
@@ -343,6 +352,7 @@
                 "headers": {
                     "contains": {
                         "Content-Type": "application/cbor",
+                        "Accept": "application/cbor",
                         "smithy-protocol": "rpc-v2-cbor"
                     }
                 }
@@ -368,6 +378,7 @@
                 "headers": {
                     "contains": {
                         "Content-Type": "application/cbor",
+                        "Accept": "application/cbor",
                         "smithy-protocol": "rpc-v2-cbor"
                     }
                 }
@@ -402,6 +413,7 @@
                 "headers": {
                     "contains": {
                         "Content-Type": "application/cbor",
+                        "Accept": "application/cbor",
                         "smithy-protocol": "rpc-v2-cbor"
                     }
                 }
@@ -427,6 +439,7 @@
                 "headers": {
                     "contains": {
                         "Content-Type": "application/cbor",
+                        "Accept": "application/cbor",
                         "smithy-protocol": "rpc-v2-cbor"
                     }
                 }
@@ -453,6 +466,7 @@
                 "headers": {
                     "contains": {
                         "Content-Type": "application/cbor",
+                        "Accept": "application/cbor",
                         "smithy-protocol": "rpc-v2-cbor"
                     }
                 }
@@ -479,6 +493,7 @@
                 "headers": {
                     "contains": {
                         "Content-Type": "application/cbor",
+                        "Accept": "application/cbor",
                         "smithy-protocol": "rpc-v2-cbor"
                     }
                 }
@@ -505,6 +520,7 @@
                 "headers": {
                     "contains": {
                         "Content-Type": "application/cbor",
+                        "Accept": "application/cbor",
                         "smithy-protocol": "rpc-v2-cbor"
                     }
                 }
@@ -528,6 +544,7 @@
                 "headers": {
                     "contains": {
                         "Content-Type": "application/cbor",
+                        "Accept": "application/cbor",
                         "smithy-protocol": "rpc-v2-cbor"
                     },
                     "doesNotContain": [
@@ -554,6 +571,7 @@
                 "headers": {
                     "contains": {
                         "Content-Type": "application/cbor",
+                        "Accept": "application/cbor",
                         "smithy-protocol": "rpc-v2-cbor"
                     },
                     "doesNotContain": [
@@ -589,4 +607,4 @@
             }
         }
     }
-]
+]