Reuse connections for 5xx errors

[zoewangg]

Motivation and Context

Reuse connections for 5xx errors for all supported HTTP clients. This change reverts #1768 and #2960

[jtjeferreira]

Hi @zoewangg,

I am working on an AWS SDK Http client based on pekko here, and the only failing test from SdkAsyncHttpClientH1TestSuite is connectionReceiveServerErrorStatusShouldNotReuseConnection which I am ignoring for now.

Luckily I stumbled upon this PR, and I am just wondering why this functionality is being reverted?

[zoewangg]

Hi @jtjeferreira, we are still evaluating the change. The main reason is that closing connections for 5xx errors could cause more TCP connection establishment in the unlikely event of outage, which could add request latency and add more load on the server side. In general, we try to keep custom logic in the SDK minimal and let the server side decide if a connection should be kept open or not.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud