Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove S3EventNotification japicmp exclusion #5804

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

L-Applin
Copy link
Contributor

Remove S3EventNotification from japicmp exclusion list. Was added to allow adding static modifier to one of the fromJson method.

@L-Applin L-Applin requested a review from a team as a code owner January 16, 2025 14:35
Copy link

@zoewangg zoewangg added this pull request to the merge queue Jan 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2025
@L-Applin L-Applin added this pull request to the merge queue Jan 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 20, 2025
@L-Applin L-Applin added this pull request to the merge queue Jan 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 20, 2025
@L-Applin L-Applin added this pull request to the merge queue Jan 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 20, 2025
@L-Applin L-Applin added this pull request to the merge queue Jan 21, 2025
Merged via the queue into master with commit 74f7529 Jan 21, 2025
17 checks passed
@L-Applin L-Applin deleted the olapplin/japi-exclu-removal branch January 21, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants